Add hostname resolution to ip #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyjpj0916
requested review from
anuj147,
dhruvd11 and
chirag-manwani
as code owners
|
Noting my colleague @chaitanya14 tested this out today in our non-prod env and confirmed DNS to IP was working as expected! |
|
@chaitanya14 I added a unit test but I am not sure if I setup hostname correctly so docker could do FDQN to IP resolution correctly. Does this look right or have you done this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the redis host to be an ip or a true resolvable hostname much like the field redis_host implies.
Uses the same libs and such that Kong uses and since this is a Kong plugin I think makes sense to just reuse their ways.