feat: trace #266
Open
feat: trace #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: surajgour-d11 <[email protected]>
Signed-off-by: surajgour-d11 <[email protected]>
surajgour-d11
force-pushed
the
feat/trace-id
branch
from
24f4e49 to
2812544
Compare
| @@ -43,6 +49,6 @@ func grpcClient(ctx *context.Context) (*grpc.ClientConn, *context.Context, error | |||
| return nil, nil, err | |||
| } | |||
| // Enrich context with authorisation metadata | |||
| requestCtx := metadata.AppendToOutgoingContext(*ctx, "Authorization", fmt.Sprintf("Bearer %s", appConfig.AccessToken)) | |||
| requestCtx := metadata.AppendToOutgoingContext(*ctx, "Authorization", fmt.Sprintf("Bearer %s", appConfig.AccessToken), "TraceId", traceID) | |||
There was a problem hiding this comment.
Let' use consistent key name TRACE_ID/TraceId/traceId/trace-id. I prefer trace-id.
https://www.w3.org/TR/trace-context/#trace-id
| appConfig := config.GetConfig() | ||
|
|
There was a problem hiding this comment.
Can we generate traceId here itself? That way we can avoid writing it in all the commands
| if err != nil { | ||
| log.Fatal("Failed to deploy service ", err) | ||
| log.Info("TraceId: ", traceID) |
There was a problem hiding this comment.
Trace id should be always be logged as a debug message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin version(x.y.z)
Features
Resources