Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse Filter Enhancement: Subtractive filtering & Improve Table Sorting #316

Open
1 of 2 tasks
Darthmaul opened this issue May 28, 2022 · 0 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@Darthmaul
Copy link
Contributor

Darthmaul commented May 28, 2022

From Discord: Message Link

Weapon choices and overclock selections should narrow down as the item "above" them is selected. For example, if a user selects Scout builds, they shouldn't see all of the primary and secondary weapons for all the other classes.

This definitely makes sense and should be a big QoL improvement.

This is going to involve some work regarding our filter JS library - Choices.js . This should be doable. It will involve filter.blade.php and maybe some backend work in LoadoutsController.php

Same with weapons and their overclocks. Shouldn't need to scroll through every overclock when I have the Minigun selected. It's cool that the search bar is a bit more interactive and the name can be filled in to quickly select it, but what if I forget the name?

Agree on this as well - I would expect to apply this behavior to all inputs once we are able to enable it.

Also, it would be nice if clicking on the "Salutes" column would first sort the list by "descending" salutes, meaning the builds with the most salutes appear at the top, followed then by an ascending order. The way it is now, I need to click and wait for a load twice before I can see the top builds in my aforementioned selection, and then twice again after each change I make to my selection.

You are right about this as well, I have noticed this myself but wasn't sure what our users felt. I have heard this a few times and I think it's worth adjusting that.

The library we are using for our tables is working on a PR for this type of functionality, and it would be a change in table.blade.php .

I will say this implementation is "Blocked" until we see that PR, but it is not a huge priority.

Will update progress in this issue.

TASKS:

  • Implement "subtractive filtering" for fields on the builder. I.e.: logical filters based on previous inputs for character, guns, oc's, etc.
  • Change Salutes default sorting to desc - wait for PR from our columnsorting library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant