Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When already a FUNDING.json present, propose editing it instead of creating #1329

Closed
efstajas opened this issue Oct 30, 2024 · 2 comments · Fixed by #1386
Closed

When already a FUNDING.json present, propose editing it instead of creating #1329

efstajas opened this issue Oct 30, 2024 · 2 comments · Fixed by #1386
Assignees

Comments

@efstajas
Copy link
Contributor

Currently, we always prompt people to create a FUNDING.json file with only information for the current network in it.

We already have a few FIL-RetroPGF-2 recipients that have claimed on Ethereum, and they'll have to claim again on Filecoin. In this case, the app should see that there's already a FUNDING.json file in the repo, and prompt you to add the new lines for the current network, instead of creating an entirely new file. The UI in the code preview could look like a Git Diff in this case, where the existing lines are greyed out, and the newly added ones have little plusses on the left and are green.

The "Add to repo" button should also say "Edit on GitHub" and propose an edit to the existing file instead.

@brandonhaslegs
Copy link
Collaborator

Changed the text a bit in certain places where it said "add" to "edit" and also added this green text with green background for the stuff you're supposed to add to the FUNDING.json file.

Image

@efstajas
Copy link
Contributor Author

Change step description to add "please add an owner address for < Network Name > [...]"

@brandonhaslegs brandonhaslegs removed their assignment Dec 3, 2024
@mhgbrown mhgbrown self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants