Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add description to drip lists (closes #642) #643

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Conversation

evvvritt
Copy link
Collaborator

@evvvritt evvvritt commented Aug 30, 2023

closes #642

  • desc on create list
  • desc on edit list
  • expands more/less if longer than 2 lines

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 1345d52
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/64ef716937be4e00085acca9
😎 Deploy Preview https://deploy-preview-643--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evvvritt evvvritt marked this pull request as ready for review August 30, 2023 16:05
@evvvritt evvvritt requested a review from efstajas August 30, 2023 16:05
@evvvritt
Copy link
Collaborator Author

@efstajas (see my discord DM) but, not sure how to resolve the svelte check.
I extended the schema in v3.ts but it still doesn't see description there.
(it passes if i add description to v1.ts and v2.ts)
any ideas?

Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code changes LGTM 👍


<div class:order-first={showListFirst}>
<FormField title="Members*">
<!-- TODO: This crashes when entering some non-valid github url -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that still a thing? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a non-valid github url?

@evvvritt evvvritt merged commit 2aa3e1d into main Sep 6, 2023
10 checks passed
@evvvritt evvvritt deleted the ev/drip-list-desc branch September 6, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Description to Drip Lists
2 participants