-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add description to drip lists (closes #642) #643
Conversation
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
839a0d2
to
6dad7c0
Compare
@efstajas (see my discord DM) but, not sure how to resolve the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Code changes LGTM 👍
|
||
<div class:order-first={showListFirst}> | ||
<FormField title="Members*"> | ||
<!-- TODO: This crashes when entering some non-valid github url --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that still a thing? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a non-valid github url?
closes #642