-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update features section (closes #649) #669
Conversation
Update text on the landing page
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help!! 💙
Ah wait sorry, can you please update your commit messages to our required formatting (Does it not flag when you try to commit locally?) Also, please remove the unused CSS indicated when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see prev comment in the PR on required changes)
Hi @evvvritt. Do you have any advice? :) Should I make a new fork and try cloning again on github desktop? |
style: Update text on the landing page and changes from 3x2 feature section to 4x1 feature section
@evvvritt I added a commit with a message with the required formatting on top of the previous commit. Does that satisfy the requirements? Also, would you mind sending me a screenshot of the unused CSS when running I tried cloning again, but I seem to have an issue with the emojis in the filenames of the icons that causes an error, so I'm working from the github website. Thank you for your patience. This is my first contribution to an open source project, and I am trying to learn my way through it. |
Hi, I would recommend trying to contribute by using tools like Visual Studio Code and git in the command line. I expect using the Github website is very limiting and it's not an effective use of our time to send screenshots of tests you can see if you setup a conventional dev environment, which I encourage you to try :) |
Fair enough. I did try to clone from VSCode, but all attempts to checkout from git haven't worked. I looked into it more, and it seems to be a MacOS illegal byte sequence issue. I will try it again on windows. |
Strange, I use MacOS + VS Code. Can you screenshot this byte sequence error please? It's probably these emoji-named files which we can rename |
I deleted the fork I made, remade it, and intend to reinitiate a PR once I get my windows dev env setup, the proper changes made + proper commit msg and an npm run check done. |
Update text on the landing page