Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update features section (closes #649) #669

Closed
wants to merge 4 commits into from
Closed

Update features section (closes #649) #669

wants to merge 4 commits into from

Conversation

christian-carey
Copy link
Contributor

Update text on the landing page

Update text on the landing page
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 1d84a49
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/650b0f719d2322000893d98a
😎 Deploy Preview https://deploy-preview-669--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@christian-carey christian-carey changed the title Update features section #649 Update features section Sep 13, 2023
@christian-carey christian-carey mentioned this pull request Sep 13, 2023
7 tasks
@christian-carey christian-carey changed the title Update features section Update features section (closes #649) Sep 13, 2023
Copy link
Collaborator

@evvvritt evvvritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!! 💙

@evvvritt
Copy link
Collaborator

Ah wait sorry, can you please update your commit messages to our required formatting (Does it not flag when you try to commit locally?)

Also, please remove the unused CSS indicated when running npm run check

@evvvritt evvvritt marked this pull request as draft September 14, 2023 12:26
Copy link
Collaborator

@evvvritt evvvritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see prev comment in the PR on required changes)

@christian-carey
Copy link
Contributor Author

christian-carey commented Sep 14, 2023

Hi @evvvritt.
I was having issues cloning with the github desktop app
Screen Shot 2023-09-14 at 9 01 38 AM
, so I forked the repo on the github browser, copied the local changes I made in pages.svelte into the code editor in the github browser and committed from the browser UI and also initiated a pull request there.
I can't find a way to update the commit message from the github browser, and I'm not sure how to run npm check on the browser github repo.

Do you have any advice? :)

Should I make a new fork and try cloning again on github desktop?

style: Update text on the landing page and changes from 3x2 feature section to 4x1 feature section
@christian-carey christian-carey marked this pull request as ready for review September 18, 2023 01:35
@christian-carey
Copy link
Contributor Author

@evvvritt I added a commit with a message with the required formatting on top of the previous commit. Does that satisfy the requirements?

Also, would you mind sending me a screenshot of the unused CSS when running npm run check so I can remove it?

I tried cloning again, but I seem to have an issue with the emojis in the filenames of the icons that causes an error, so I'm working from the github website.

Thank you for your patience. This is my first contribution to an open source project, and I am trying to learn my way through it.

@evvvritt
Copy link
Collaborator

Hi, I would recommend trying to contribute by using tools like Visual Studio Code and git in the command line. I expect using the Github website is very limiting and it's not an effective use of our time to send screenshots of tests you can see if you setup a conventional dev environment, which I encourage you to try :)

@christian-carey
Copy link
Contributor Author

Fair enough. I did try to clone from VSCode, but all attempts to checkout from git haven't worked. I looked into it more, and it seems to be a MacOS illegal byte sequence issue. I will try it again on windows.

@christian-carey christian-carey closed this by deleting the head repository Sep 20, 2023
@evvvritt
Copy link
Collaborator

Strange, I use MacOS + VS Code. Can you screenshot this byte sequence error please? It's probably these emoji-named files which we can rename

@christian-carey
Copy link
Contributor Author

image
I believe it is the emoji-name files. I was able to successfully clone the repo on Windows through VSCode, so I'm working on setting up my dev environment there

@christian-carey
Copy link
Contributor Author

I deleted the fork I made, remade it, and intend to reinitiate a PR once I get my windows dev env setup, the proper changes made + proper commit msg and an npm run check done.

@christian-carey
Copy link
Contributor Author

christian-carey commented Sep 21, 2023

Screen Shot 2023-09-21 at 4 02 58 PM

I had problems with windows npm, so I went back to mac. I am having issues with the files with emoji names.

Screen Shot 2023-09-21 at 4 09 43 PM

Would this be an issue when I redo the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants