Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: existing drip list editor broken #686

Merged
merged 3 commits into from
Sep 26, 2023
Merged

fix: existing drip list editor broken #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53fb94
fix: drip list editor not updating drip list
efstajas Sep 26, 2023
f9da6e2
test: ensure drip list editing properly tested
efstajas Sep 26, 2023
c114347
Merge branch 'main' into jason/hotfix-drip-list-editor
efstajas Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/e2e-tests/top-up-create-stream.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,7 @@ describe('app', async () => {

await expect(page.locator('text=This is an EDITED title')).toHaveCount(1);
await expect(page.locator('text=This is an EDITED description.')).toHaveCount(1);
await expect(page.locator('text=drips-test-repo-11')).toHaveCount(1);
await expect(page.locator('text=0x43')).toHaveCount(0);
});

Expand Down
5 changes: 1 addition & 4 deletions src/lib/flows/edit-drip-list/steps/edit-drip-list.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,7 @@
const callerClient = await getCallerClient();

const { receivers, projectsSplitMetadata } =
await dripListService.getProjectsSplitMetadataAndReceivers({
percentages,
items,
});
await dripListService.getProjectsSplitMetadataAndReceivers(dripList);

const setSplitsTx = await nftDriverTxFactory.setSplits(dripListId, receivers);

Expand Down
Loading