Revert "Add svelte check in pre-commit hook" #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO there are a few workflow problems with this:
svelte-check
to scan the entire repo for every individual commit, even if you already ran svelte-check before and know there's no issues in the repo. You can skip commit verification of course, but then you're also skippinglint-staged
and may commit badly formatted code.IMO, it's enough to have svelte-check ran as a check on PRs, which still finishes pretty quickly and effectively prevents bad changes from ending up on main. Of course, you can also run
npm run check
on-demand anytime you want locally.