-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load optimized Inter fonts (closes #709) #710
Conversation
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah true, it looks like I can preserve them in the optimizer from font-squirrel (options below). Though I'm having trouble identifying some of the other font features we have in our css: (@brandonhaslegs dyk?)
|
ah wait found this CSS tricks guide
|
You can see them all here: https://rsms.me/inter/lab/ |
|
Ok thanks, of course when I enable tabular numbers in the generator it breaks 🤣 |
It's a "known bug" that the font files aren't included in expert mode - but realistically no fix in sight. @efstajas / @brandonhaslegs do you guys know other ways to optimize the .otf's into .woff with our font features enabled? |
@evvvritt if you have the optimized OTF's, then you can just convert them to WOFF's on cloudconvert.com. |
Ok I used cloudconvert to just convert the full .otf and they each reduce from ~250kb to ~100kb, and tabular-nums are preserved. I can't find an alternative service to optimize them further but think this is a solid improvement. Will reduce font load from ~750kb to ~200kb |
loads local .woff2 files (overwrites
radicle-design-system/typography.css
@font-face
rules)alternatively, we could update the
radicle-design-system
css + font files but I don't have write access so thought this was fastertested on deploy and it properly loads the .woff2 files instead of the .otf (locally it sometimes loads the .otf)