Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: rmv 'funds' in Add modal (closes #719) #726

Merged
merged 2 commits into from
Oct 10, 2023
Merged

style: rmv 'funds' in Add modal (closes #719) #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06c3fb9
style: rmv 'funds' in Add modal
evvvritt Oct 9, 2023
f0ee258
Merge branch 'main' into ev/iss719
evvvritt Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/flows/top-up-flow/enter-amount.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
<StepLayout>
<EmojiAndToken emoji="💰" tokenAddress={tokenInfo.info.address} animateTokenOnMount />
<StepHeader
headline={`Add ${tokenInfo?.info.symbol ?? ''} funds`}
headline={`Add ${tokenInfo?.info.symbol}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we had a default '' value before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear to me, but the changes match what we have in Withdraw modal (no ' ' fallback)

description="Add funds to your Drips account's outgoing balance."
/>
<FormField title="Wallet balance">
Expand Down
Loading