Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBConvert does not handle SVG correctly causing docs build to fail #68

Closed
github-actions bot opened this issue Aug 12, 2022 · 6 comments · Fixed by #100
Closed

NBConvert does not handle SVG correctly causing docs build to fail #68

github-actions bot opened this issue Aug 12, 2022 · 6 comments · Fixed by #100

Comments

@github-actions
Copy link
Contributor

GitHub Actions workflow tests #222 failed.

Event: push
Branch: main
Commit: f57fb4eefb8e1f80476342f7de8fd2b1f84b9d5b

Created by jayqi/failed-build-issue-action
@github-actions
Copy link
Contributor Author

GitHub Actions workflow tests #223 failed.

Event: schedule
Branch: main
Commit: f57fb4eefb8e1f80476342f7de8fd2b1f84b9d5b

Created by jayqi/failed-build-issue-action

@github-actions
Copy link
Contributor Author

GitHub Actions workflow tests #224 failed.

Event: schedule
Branch: main
Commit: f57fb4eefb8e1f80476342f7de8fd2b1f84b9d5b

Created by jayqi/failed-build-issue-action

@github-actions
Copy link
Contributor Author

GitHub Actions workflow tests #225 failed.

Event: schedule
Branch: main
Commit: f57fb4eefb8e1f80476342f7de8fd2b1f84b9d5b

Created by jayqi/failed-build-issue-action

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2022

GitHub Actions workflow tests #226 failed.

Event: schedule
Branch: main
Commit: f57fb4eefb8e1f80476342f7de8fd2b1f84b9d5b

Created by jayqi/failed-build-issue-action

@pjbull pjbull mentioned this issue Sep 6, 2022
Merged
@pjbull pjbull changed the title Failed build: tests NBConvert does not handle SVG correctly causing docs build to fail Sep 6, 2022
@pjbull
Copy link
Member

pjbull commented Sep 6, 2022 •
edited
Loading

Temporary fix in #69 to hold back nbconvert to working version (<6.4).

Keeping this issue open to remove the pin once SVG rendering is working again in nbconvert: jupyter/nbconvert#1849

@jayqi jayqi removed the build failed label Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@drivendataorg drivendataorg deleted a comment from github-actions bot Feb 9, 2023
@jayqi
Copy link
Member

jayqi commented Sep 14, 2023

This may have addressed things—need to check: jupyter/nbconvert#2018

@jayqi jayqi mentioned this issue Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update nbconvert to after SVG fix drivendataorg/erdantic
2 participants
@pjbull @jayqi