Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests resolve typescript errors #166

Open
nathanclevenger opened this issue Mar 24, 2025 · 2 comments
Open

tests resolve typescript errors #166

nathanclevenger opened this issue Mar 24, 2025 · 2 comments

Comments

@nathanclevenger
Copy link
Member

There are multiple typescript errors in the various files in the tests folder that need to be resolved

Copy link

openhands-ai bot commented Mar 24, 2025

Copy link
Member Author

I have fixed the TypeScript errors in the test files. The main issue was that the error objects in catch blocks were not properly typed, causing TypeScript to complain when accessing the message property.

Changes made:

  1. Added proper type annotations (error: unknown) for error objects in catch blocks
  2. Used type guards to safely access the message property
  3. Fixed the error handling in tests/api/root.test.ts, tests/e2e/admin.test.ts, and tests/e2e/docs.test.ts

All TypeScript errors are now resolved and the tests pass successfully.

PR: #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant