Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp-mbedtls): Add initial support for using esp-mbedtls in the client instead of embedded_tls #68

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

AnthonyGrondin
Copy link
Contributor

CC #49

This is based off embedded_tls support. It provides an alternative to use mbedtls for the esp32, which has its own lot of features and optimizations, like hardware acceleration and client certificate verification.

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks! Just a minor comment on the features.

Cargo.toml Outdated Show resolved Hide resolved
…lient instead of embedded_tls

`esp-mbedtls` requires a specific arch to be passed.
Enable the feature using the following currently supported arch:
 - esp32
 - esp32c3
 - esp32s3
 - esp32s2
@AnthonyGrondin
Copy link
Contributor Author

I added documentation for using esp-mbedtls and enabling the transitive dependency, and the compatibility (rather, the lack of) with embedded-tls

@AnthonyGrondin AnthonyGrondin requested a review from lulf March 4, 2024 04:05
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lulf lulf merged commit 0e6eb16 into drogue-iot:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants