Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate certs using instance id #198

Open
bradrydzewski opened this issue Nov 11, 2022 · 0 comments
Open

generate certs using instance id #198

bradrydzewski opened this issue Nov 11, 2022 · 0 comments

Comments

@bradrydzewski
Copy link
Contributor

this depends on generating a unique server name, per this issue:
#197

we should use the instance id when generating the cert, not the runner name. The server name in the cert needs to be unique and resilient to restarts. Currently the runner name can change if the pod is re-created, which would invalidate all certs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant