Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken img links shown for users who don't have an email addr #138

Open
geeksville opened this issue Dec 15, 2014 · 2 comments
Open

broken img links shown for users who don't have an email addr #138

geeksville opened this issue Dec 15, 2014 · 2 comments
Assignees
Labels

Comments

@geeksville
Copy link
Collaborator

I think something is probably not checking that the avatar URL is valid...

@mrpollo
Copy link
Member

mrpollo commented Dec 15, 2014

we should probably add a default if theres no email present

@geeksville
Copy link
Collaborator Author

I totally agree - the FE used to have code in there to use the placeholder gravatar if the url wasn't provided by the server (or the backend might have been doing that - I'll check later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants