fix leaking snapshot stats

drpcorg · Dec 24, 2024 · ba34452 · ba34452
1 parent 9468ee8
commit ba34452
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/sync.go b/sync.go
@@ -251,7 +251,13 @@ func (sync *Syncer) Feed(ctx context.Context) (recs protocol.Records, err error)
 			} else {
 				sync.SetFeedState(ctx, SendEOF)
 			}
-			_ = sync.snap.Close()
+
+			err = sync.snap.Close()
+			if err != nil {
+				sync.log.ErrorCtx(sync.logCtx(ctx), "sync: failed closing snapshot", "err", err)
+			} else {
+				OpenedSnapshots.WithLabelValues(sync.Name).Set(0)
+			}
 			sync.snap = nil
 			err = nil
 		}