feat(dataproducer): make access check optional in entity_label (#1382) #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to fix the tests |
|
BTW this is related to https://www.drupal.org/sa-contrib-2023-050 |
|
The issue with the tests is actually a bug in DataProducerExecutionTrait and has an issue for it: #1233 DataProducerExecutionTrait does not care about the dafault value, so it needs to be specified. I just made a workarround for the tests with a todo that marks that the 'access' default value can be removed after that issue is fixed. |
klausi
requested changes
May 30, 2024
edurenye
force-pushed
the
1382-entity_label_access
branch
from
85377f7 to
b1c88c8
Compare
|
Thanks, development has moved - please open issues on drupal.org: https://www.drupal.org/project/issues/graphql Please also add a test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1382