-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to select Java in Minecraft 1.21 (Tested on Mac computers with Apple Slicon) #9
Comments
This same issue also exists in Minecraft 1.12.2 with the Forge mod loader installed, which requires Java 8. |
These are the default java rules https://github.com/dscalzi/helios-core/blob/master/lib/common/distribution/DistributionFactory.ts#L133 |
You can configure different rules if you need to https://github.com/dscalzi/HeliosLauncher/blob/master/docs/distro.md#javaoptions-object |
Appears to be an issue with the semver function 2e37936#diff-2de96283ccb9afe0df455134caa33d845a0f5181a4ff12783a48f869552a96adR52 Will stop using that |
i'll push out a new version in a few days |
Until that is pushed, you should be able to work around this by just including the following in your {
"meta": {
"javaOptions": {
"supported": ">=21",
"suggestedMajor": 21
}
}
} |
semver.satisfies is also used in JavaGuard, and I think it may not work correctly in certain situations. For example, when my intention is >=8, if I select version 11 of Java, it will return false. |
Is this still an issue? |
In macos environment, when using java 17 for Minecraft 1.20.1, java is detected normally, but when trying to use java 21 for Minecraft 1.21, the error "Invalid Selection" is output and there is a problem that cannot be executed.
I think there was an update from helios-core in this regard, but it still seems to be an issue.
#7
I used the launcher source in almost the same state as the original (modifying distribution url only. last commit: eb683f8), and my distribution.json file is as attached below. (Note: The actual URL was replaced by localhost for security)
distribution.json
The text was updated successfully, but these errors were encountered: