Merge pull request #111 from dsccommunity/DSC_ParameterStateUpdate

Updating Resources for new DSCResource.Common
dsccommunity · Sep 14, 2022 · 0d2f470 · 0d2f470
2 parents 75c7d26 + 24043d3
commit 0d2f470
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed issue in Reverse DSC that affected collection query capture
 when collection queries have quotes.
 
+- Fixed an issue causing some tests to unexpectedly fail with a newer
+version of DSCResource.Common
+
 ## [3.0.0] - 2022-01-03
 
 ### Added

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -22,7 +22,7 @@ stages:
       - job: Package_Module
         displayName: 'Package Module'
         pool:
-          vmImage: 'ubuntu 18.04'
+          vmImage: 'ubuntu 20.04'
         steps:
           - pwsh: |
               dotnet tool install --global GitVersion.Tool
@@ -157,7 +157,7 @@ stages:
         displayName: 'Publish Code Coverage'
         dependsOn: Test_Unit
         pool:
-          vmImage: 'ubuntu 18.04'
+          vmImage: 'ubuntu 20.04'
         timeoutInMinutes: 0
         steps:
           - pwsh: |
@@ -207,7 +207,7 @@ stages:
       - job: Deploy_Module
         displayName: 'Deploy Module'
         pool:
-          vmImage: 'ubuntu 18.04'
+          vmImage: 'ubuntu 20.04'
         steps:
           - task: DownloadBuildArtifacts@0
             displayName: 'Download Build Artifact'

diff --git a/source/DSCResources/DSC_CMDistributionPoint/DSC_CMDistributionPoint.psm1 b/source/DSCResources/DSC_CMDistributionPoint/DSC_CMDistributionPoint.psm1
@@ -592,7 +592,7 @@ function Test-TargetResource
                                 'EnableBranchCache','EnableLedbat')
             }
 
-            $result = Test-DscParameterState @testParams -Verbose
+            $result = Test-DscParameterState @testParams -Verbose -TurnOffTypeChecking
 
             if ($BoundaryGroups)
             {

diff --git a/source/DSCResources/DSC_CMPxeDistributionPoint/DSC_CMPxeDistributionPoint.psm1 b/source/DSCResources/DSC_CMPxeDistributionPoint/DSC_CMPxeDistributionPoint.psm1
@@ -331,7 +331,7 @@ function Test-TargetResource
                 'PxeServerResponseDelaySec','UserDeviceAffinity')
         }
 
-        $returnValue = Test-DscParameterState @testParams -Verbose
+        $returnValue = Test-DscParameterState @testParams -Verbose -TurnOffTypeChecking
 
         if ((-not [string]::IsNullOrEmpty($PxePassword)) -and ([string]::IsNullOrEmpty($state.PxePassword)))
         {

diff --git a/source/DSCResources/DSC_CMReportingServicePoint/DSC_CMReportingServicePoint.psm1 b/source/DSCResources/DSC_CMReportingServicePoint/DSC_CMReportingServicePoint.psm1
@@ -321,7 +321,7 @@ function Test-TargetResource
                 ValuesToCheck = ('DatabaseName','DatabaseServerName','Username','FolderName','ReportServerInstance')
             }
 
-            $result = Test-DscParameterState @testParams -Verbose
+            $result = Test-DscParameterState @testParams -Verbose -TurnOffTypeChecking
 
             if ($FolderName -or $ReportServerInstance)
             {

diff --git a/source/DSCResources/DSC_CMSiteSystemServer/DSC_CMSiteSystemServer.psm1 b/source/DSCResources/DSC_CMSiteSystemServer/DSC_CMSiteSystemServer.psm1
@@ -454,7 +454,7 @@ function Test-TargetResource
                 ValuesToCheck = @('PublicFqdn','FdmOperation','UseSiteServerAccount','AccountName')
             }
 
-            $result = Test-DscParameterState @testParams -Verbose
+            $result = Test-DscParameterState @testParams -Verbose -TurnOffTypeChecking
 
             $proxyCheck = @('EnableProxy','ProxyServerName','ProxyServerPort','ProxyAccessAccount')