VhdFileDirectory - improvements and fixes to Content files #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otherwise they are always written as Unicode) which corrupts some content types like UTF-8 XMLs. 2. Content files are not tested with ItemHasChanged (this didn't work anyway). 3. Fixed GetItemToCopy where an undefined DefaultValues array was used instead of DesiredProperties, resulting in a dead code, impacting properties like Force. 4. After dsccommunity#3 is fixed and the code is finally execuded, it would crash if a file is a Content (without SourcePath). 5. In SetVHDFile , Copy-Item's ErrorAction is set to Stop. Otherwise, the resource would simply ignore all errors and produce invalid configuration.
Codecov Report
@@ Coverage Diff @@
## dev #179 +/- ##
===================================
- Coverage 73% 73% -1%
===================================
Files 11 11
Lines 1401 1402 +1
===================================
Hits 1035 1035
- Misses 366 367 +1 |
|
Hi Dmitry, can you please open an issue for this feature so that we have more context? Also, could you add appropriate tests for the new functionality please? Thanks for the contribution! |
aromano2
added
the
waiting for author response
|
We have renamed the resource, removing 'x', so please rebase this PR. |
johlju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
None
This change is