Skip to content

Contributing to SharePointDsc

Jump to bottom
Yorick Kuijs edited this page Apr 25, 2019 · 25 revisions

If you are keen to make SharePointDsc better, why not consider contributing your work to the project? Every little change helps us make a better resource for everyone to use, and we would love to have contributions from the community.

Core contribution guidelines

We follow all of the standard contribution guidelines for DSC resources outlined in the DscResources repo, so please review these as a baseline for contributing. Specifically, be sure to read the following linked articles from that page:

SharePointDsc specific coding principles

The Get-TargetResource function should not return $null as a result. It may, however, return a hashtable where some properties have a $null value. For example:

function Get-TargetResource
{
	$nullreturn = @{
            ServiceAppName = $ServiceAppName
            Name = $Name
            RequestLimit = $null
            WaitTime = $null
            Ensure = "Absent"
	}
	return $nullreturn
}

In some cases, SharePoint does not publically publish information via the object model. If this is the case, reflection can be used to call the internal method. Since this comes with significant risks, however, we only allow reflection to be used to retrieve data and not to set data.

Design Guidelines

To help ensure that SharePointDsc resources are created in a consistent manner, there are a number of design guidelines that guide the thinking applied to how the resources should be built. These design rules should be taken into account when submitting changes or new functionality to the SharePointDsc module.

  1. Each resource in SharePointDsc should strive to make changes to only the current server, and not require a remote connection to other servers to complete their work.
  2. Supported versions of SharePoint for SharePointDsc are SharePoint Server 2013 with Service Pack 1 or higher, SharePoint Server 2016 and SharePoint Server 2019. SharePoint 2010 will not be supported due to requiring PowerShell 4, which is not supported with that version of the product. Where a resource will not work with all versions we support (such as functionality or features being added or deprecated between versions), a clear and concise error should be returned that explains this.
  3. Any breaking change should be committed to a new branch so that it can be included in the next major version release. A change will be considered a 'breaking' change under the following circumstances:
  • A new mandatory property is added to a resource
  • The data type of any resource property is changed
  • Any property is removed or renamed in a resource
  • A resource is removed
  • A change in the expected outcome of how a resource behaves is made
  • Any change that modifies the list of prerequisites for the module to run
  1. Resources that will make changes within site collections should not be part of SharePointDsc. The reason is that these types of changes can conflict with actions performed by the site collection owners/administrators. For example: In SPSite we use the title field during site creation, but do not update the title later on. This is because a site collection administrator can have a reason for changing the title and in such a case, SharePointDsc would reset the title, confusing the site collection administrator.
  • Only in specific cases can we deviate from this principle.
  • One exception is the SPWeb resource. That was fully coded already and submitted as a Pull Request. Since we didn't want to throw away that code, we decided to include it into the module.

SharePointDsc specific guidelines

Dynamic documentation

With over 100 resources in our module, we want to keep the documentation work light. To aid this, we are generating our documentation dynamically. Therefore, for each DSC resource we have, the following items must be completed so we can generate these:

  1. In the folder for the resource, place a readme.md file that contains heading 'Description' and a text description of the module.
  2. In the schema.mof file for the resource, ensure that there are description attributes on all properties.
  3. Generate 1 or more example configurations for the resource in the Examples/resources/[resource name] folder using PowerShell help syntax to describe the example at the top of the file. Each example configuration must be complete and runnable, must be called "example" and it must only take parameters of PSCredential types. This will allow our unit tests to validate the examples as part of our build process.

With these items in place, we can dynamically generate the help files for PowerShell as well as this wiki.

Testing against SharePoint Server 2013, SharePoint Server 2016 and SharePoint Server 2019

SharePointDsc is designed to work correctly against the Server 2013, 2016 and 2019 versions of the product. The automated unit tests that are run in SharePointDsc will execute against all versions of the product using the stub modules we include in the unit tests directory.

Where a resource applies to only a specific version (such as xSPUserProfileSyncService) the code should throw meaningful errors to indicate that it should not be used with the installed version of the product.

Test your changes on a SharePoint test environment

This might sound a little stupid, but in the past we noticed that code changes were submitted that could never work on a SharePoint environment. So always make sure you test your updates against a real life SharePoint environment! You can use this article to create your own test environment in Azure.

Tools

For SharePointDsc there are several tools available to help developing or are being used in the GitHub repository.

GitHub Desktop

In order to work with a local copy of the repository, you need the GitHub Desktop. The GitHub Desktop include the Git tools, but adds a nice GUI on top of it. Using this GUI you can see what commits have been made and what changes where made in those commits. Checkout the training section below if you want to learn more about Git.

Visual Studio Code

To develop SharePointDsc, we recommend the use of Visual Studio Code with the PowerShell extension to enable PowerShell support. The SharePointDsc project already contains some definitions that configure Visual Studio Code to use the correct formatting.

PSScriptAnalyzer

To check code for compliance to PowerShell best practices, we are using PSScriptAnalyzer. You can install this module locally as well and have your code checked. Visual Studio Code is also using this module to display possible issues in your PowerShell code.

AppVeyor

We are using AppVeyor as the Continuous Integration solution for our project. When a Pull Request is submitted, AppVeyor will run all the required tests. If you want to see what happened, for example if the test fails, you can review the AppVeyor log by clicking on the "Details" link behind the AppVeyor test.

Since the AppVeyor log currently has more than 12.000 lines, a quick way to see which tests failed is to click the "TESTS" link (third menu option, just above the blue AppVeyor log window). That will show you all the test results, starting with the failed tests.

Pester

All DSC Resource Kit modules are using Pester to perform Unit tests on the code. Pester is also able to calculate the code coverage off all tests. Check out the training section below if you want to learn more about Pester.

You can run all tests by performing these steps:

  • Open PowerShell
  • Browse to the Tests folder in the SharePointDsc module
  • Run "Import-Module .\TestHarness.psm1"
  • Run "Invoke-TestHarness" This executes all tests on the code. This can take up to an hour, depending on the specifications of your machine.

We are also checking for compliance to the coding style guide and other generic tests. You can run these tests locally by executing the following steps:

  • First make sure your machine is setup for running Gulp - (Required only once)
  • Clone the DscResource.Tests repository to your local SharePointDsc copy (project is configured to ignore the DscResource.Tests folders) - (Required only once) 
    cd <module_path>\Modules\SharePointDsc
git clone https://github.com/PowerShell/DscResource.Tests.git
  • Run the generic tests 
    cd <module_path>\Modules\SharePointDsc
Invoke-Pester -Script "<module_path>\Modules\SharePointDsc\DscResource.Tests\Meta.Test.ps1"

It is also possible to run the tests for just one resource:

  • To run an individual Pester test, browse to the unit test folder in the project (\Tests\Unit) and run the ps1 file of the resource. That will run the tests for SP2013.

    $resource = "SPSite"
.\SharePointDsc.$resource.Tests.ps1

  • If you want to run the tests for SP2016, run the following commands (Replace the module_path tag with the correct value for your situation):

    $resource = "SPSite"
$path16 = "<module_path>\Tests\Unit\Stubs\SharePoint\16.0.4456.1000\Microsoft.SharePoint.PowerShell.psm1"
.\SharePointDsc.$resource.Tests.ps1 -SharePointCmdletModule $path16

  • If you want to check the code coverage and see which lines are not yet covered, run the following commands for SharePoint 2013:

    $resource = "SPSite"
Invoke-Pester .\SharePointDsc.$resource.Tests.ps1 -CodeCoverage <module_path>\Modules\SharePointDsc\DSCResources\MSFT_$resource\MSFT_$resource.psm1

  • If you want to check the code coverage and see which lines are not yet covered for all versions of SharePoint, run the following commands (Replace the module_path tag with the correct value for your situation):

    $resource = "SPSite"
$path15 = "<module_path>\Tests\Unit\Stubs\SharePoint\15.0.4805.1000\Microsoft.SharePoint.PowerShell.psm1"
$path16 = "<module_path>\Tests\Unit\Stubs\SharePoint\16.0.4456.1000\Microsoft.SharePoint.PowerShell.psm1"
Invoke-Pester -Script @(@{ Path =  ".\SharePointDsc.$resource.Tests.ps1"; Parameters = @{SharePointCmdletModule = $path15 } },@{ Path =  ".\SharePointDsc.$resource.Tests.ps1"; Parameters = @{SharePointCmdletModule = $path16 } }) -CodeCoverage <module_path>\Modules\SharePointDsc\DSCResources\MSFT_$resource\MSFT_$resource.psm1

NOTE: Make sure you have the latest version of Pester. Update the module from the PowerShell Gallery by running the command Find-Module Pester | Update-Module

NOTE 2: If you have Windows 10, please read to successfully update to the most recent version: https://github.com/pester/Pester/wiki/Installation-and-Update

NOTE 3: When you are troubleshooting Pester tests and you make a code change in the resource, you have to restart your PowerShell session to make sure the new code is loaded and tested! Updates to the Pester test itself do not require this.

CodeCov

We are using CodeCov to check the overall code coverage across all supported versions. For the entire project, we require an 80% code coverage (currently at 91%). Each new Pull Request should therefore have a code coverage lower than 5% below the current coverage. For all new lines in a Pull Request, tests should at least cover 87% (92% - 5%) of these new lines. We will not be able to merge the Pull Request if these thresholds are not met.

Reviewable

When a Pull Request is submitted, a code review will have to take place to ensure it meets all defined standards. The code review will be done via Reviewable, a platform that easily enables reviewers to check code changes, add comments and approve changes. Only when all review comments are resolved will we be able to merge the Pull Request.

Troubleshooting

The Microsoft Docs site has a good article on troubleshooting DSC which has a list of tips and tricks on how to collect information while troubleshooting DSC.

When troubleshooting an issue, you can use the built-in debugging possibilities in PowerShell DSC. Running the command Enable-DscDebug -BreakAll on the target machine enables debugging. By running Start-DscConfiguration and specifying the configuration to deploy, a new deployment starts, stopping with the following information:

Enter-PSSession -ComputerName TEST-SRV -Credential <credentials>
Enter-PSHostProcess -Id 9000 -AppDomainName DscPsPluginWkr_AppDomain
Debug-Runspace -Id 9

By running these commands, you connect to the remote machine, entering a debug session.

Another debug option is to open the Pester file and the resource psm1 file. By placing breakpoints in those files and running the Pester file, PowerShell stops at the set breakpoint. This enables you to step through the code, troubleshooting either the resource or the Pester test.

Training

The following resources can be used to get familiar with several technologies used within SharePointDsc:

NOTE: A subscription is required for the PluralSight trainings

SharePointDSC

SharePointDsc Module

Clone this wiki locally