Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for Firebase App Distribution #107

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

Thesmader
Copy link
Member

@Thesmader Thesmader commented Dec 29, 2020

See: Dart define environment variables and using them in android.
Workflow added for alpha testers to start receiving test builds in their emails via Firebase App Distribution. The workflow is specified in .github/workflows/build.yaml. Workflow will be triggered when a commit is pushed to development branch and there are changes in elaichi directory. build.gradle(app) is now configured to generate release APK with debug signing keys for CI and local environments. Run flutter build apk --release for this. To generate a signed APK/AAB for pushing to Google Play Store, run: flutter build apk(or appbundle) --release --dart-define=ENV=prod.

See: [Dart define environment variables and using them in android](https://itnext.io/flutter-1-17-no-more-flavors-no-more-ios-schemas-command-argument-that-solves-everything-8b145ed4285d).
Workflow added for alpha testers to start receiving test builds in their
emails via Firebase App Distribution. The workflow is specified in
`.github/workflows/build.yaml`. Workflow will be triggered when a commit
is pushed to `development` branch and there are changes in `elaichi`
directory. `build.gradle(app)` is now configured to generate release APK
with debug signing keys for CI and local environments. Run `flutter
build apk --release` for this. To generate a signed APK/AAB for pushing to
Google Play Store, run: `flutter build apk(or appbundle) --release
--dart-define=ENV=prod`.
Tags: github-actions, CI, gradle, app-distribution
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@daf848d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #107   +/-   ##
==============================================
  Coverage               ?   62.99%           
==============================================
  Files                  ?       11           
  Lines                  ?      127           
  Branches               ?        0           
==============================================
  Hits                   ?       80           
  Misses                 ?       47           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf848d...7043cf7. Read the comment docs.

Copy link
Member

@DesignrKnight DesignrKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with blind hope
CC: @HarishTeens and @roshankshaw
Cheers to our https://github.com/dscnitrourkela/project-dates workflow days, 60-100 commits

@DesignrKnight
Copy link
Member

Hey add this to README.md or somewhere easily referenceable

Google Play Store, run: flutter build apk(or appbundle) --release --dart-define=ENV=prod.

@@ -0,0 +1,36 @@
name: App Distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: App Distribution
name: App Distribution via Firebase for Internal Testing

@DesignrKnight DesignrKnight linked an issue Dec 29, 2020 that may be closed by this pull request
44 tasks
@DesignrKnight
Copy link
Member

Partial Fix for #78

@Thesmader Thesmader removed a link to an issue Dec 29, 2020
44 tasks
@Thesmader Thesmader merged commit 89e5d36 into dscnitrourkela:development Dec 30, 2020
@Thesmader Thesmader deleted the app-dist branch June 7, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants