Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer should backup before deleting #44

Open
dylanrenwick opened this issue Dec 21, 2016 · 3 comments
Open

Installer should backup before deleting #44

dylanrenwick opened this issue Dec 21, 2016 · 3 comments

Comments

@dylanrenwick
Copy link
Collaborator

The installer should create a backup before deleting Assembly-Csharp.dll, as if redownloading the file from steam fails for any reason, it renders the game unplayable

@dylanrenwick dylanrenwick self-assigned this Dec 21, 2016
@dsisco11
Copy link
Owner

Im fairly sure it does, though it isn't apparent in the code, it should be calling a function that makes a backup before it deletes the original and triggers the steam cache verification.

@dsisco11
Copy link
Owner

Nevermind you are correct. The program currently assumes that if the assembly needs to be "cleaned"(redownloaded) that it is already tainted in some way and useless. However; that's a very bad thing for it to assume.

@dylanrenwick
Copy link
Collaborator Author

Yup, I did however notice that a much older version of SRPL (v0.4) did in fact make a backup, which is what gave me the idea in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants