Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid mixing cloud and SSH fleet configuration properties #2223

Open
jvstme opened this issue Jan 24, 2025 · 0 comments
Open

Forbid mixing cloud and SSH fleet configuration properties #2223

jvstme opened this issue Jan 24, 2025 · 0 comments
Labels

Comments

@jvstme
Copy link
Collaborator

jvstme commented Jan 24, 2025

Problem

It is not always clear which fleet configuration properties are relevant for cloud fleets and which are relevant for SSH fleets.
This leads users to compose configurations with both cloud and SSH properties.

type: fleet

# SSH properties
ssh_config:
  user: "user"
  identity_file: /home/user/.ssh/dstack
  hosts:
    - 127.0.0.1
  port: 2261

# Cloud properties
resources:
  cpu: 7
  memory: 10GB
  disk: 15GB

In that case dstack provisions an SSH fleet and ignores the cloud properties silently, which is highly likely to cause misunderstandings. Example:

it completely ignored declared resource request with CPU 7, 10GB RAM and 15GB Volume

Solution

Validate fleet configurations and show errors if cloud and SSH properties are mixed.

Implementation note

This can be implemented by adding validators on top of the existing configuration structure or by rethinking the configuration structure, e.g. moving cloud and SSH properties to different mappings or even introducing different configuration (sub)types for cloud and SSH fleets.

@jvstme jvstme added enhancement A non-feature improvement fleets ssh-fleets ux labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant