Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ioda2nc to support version 3 IODA files #2640

Closed
21 tasks
j-opatz opened this issue Aug 7, 2023 · 1 comment · Fixed by #2674
Closed
21 tasks

Update ioda2nc to support version 3 IODA files #2640

j-opatz opened this issue Aug 7, 2023 · 1 comment · Fixed by #2674
Assignees
Labels
MET: PreProcessing Tools (Point) priority: bold for release notes Issue should be bolded in release notes priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@j-opatz
Copy link
Contributor

j-opatz commented Aug 7, 2023

Describe the Enhancement

A user in the Discussions forum alerted the MET team to a new aspect of version 3 IODA files that is currently unsupported by MET. Namely, the nlocs variable has been replaced by Location. This causes an error in the current ioda2nc tool run, as library code relies on nlocs to pull out relevant field information.

I suggest we enhance the current ioda2nc tool to support this update to IODA files, as well as any other enhancements that may have occurred between version 2 and 3.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.
2792543 NOAA Base METplus

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@j-opatz j-opatz added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: PreProcessing Tools (Point) priority: high High Priority priority: bold for release notes Issue should be bolded in release notes labels Aug 7, 2023
@j-opatz j-opatz added this to the MET 12.0.0 milestone Aug 7, 2023
@JohnHalleyGotway
Copy link
Collaborator

@hsoh-u recommend adding one more mapping option to the Config file:
https://github.com/dtcenter/MET/blob/main_v11.1/data/config/IODA2NCConfig_default

To handle the dimension names.

@hsoh-u hsoh-u moved this from 🔖 Ready to 🏗 In progress in MET-12.0.0 Development Aug 24, 2023
hsoh-u pushed a commit that referenced this issue Aug 31, 2023
hsoh-u pushed a commit that referenced this issue Aug 31, 2023
hsoh-u pushed a commit that referenced this issue Aug 31, 2023
hsoh-u pushed a commit that referenced this issue Aug 31, 2023
@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 31, 2023 that will close this issue
15 tasks
hsoh-u pushed a commit that referenced this issue Aug 31, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 👀 In review in MET-12.0.0 Development Aug 31, 2023
@hsoh-u hsoh-u removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 1, 2023
@hsoh-u hsoh-u moved this from 👀 In review to ✅ Done in MET-12.0.0 Development Sep 5, 2023
@hsoh-u hsoh-u closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: PreProcessing Tools (Point) priority: bold for release notes Issue should be bolded in release notes priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

3 participants