Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix compilation script logic for successful dependent library compilations #3092

Open
9 of 23 tasks
jprestop opened this issue Feb 26, 2025 · 0 comments · May be fixed by #3093 or #3094
Open
9 of 23 tasks

Bugfix: Fix compilation script logic for successful dependent library compilations #3092

jprestop opened this issue Feb 26, 2025 · 0 comments · May be fixed by #3093 or #3094
Assignees
Labels
component: build process Build process issue priority: high High Priority requestor: METplus Team METplus Development Team type: bug Fix something that is not working

Comments

@jprestop
Copy link
Collaborator

jprestop commented Feb 26, 2025

Describe the Problem

Upon installing MET-12.0.2 on Frontera using the Intel one API compilers version 2023.2.1, I encountered a problem with the jasper library requiring a tweak to the command used to compile jasper.
Upon installing MET-12.0.2 on casper with the following modules loaded:

module load ncarenv/24.12
module load intel/2024.2.1
module load cmake/3.31.0

I tried using the proj/9.2.1 library available on casper, however, I needed to set MET_PROJLIB and MET_PROJINC. After setting those values, the script still tried to compile proj because it wasn't checking for values for MET_PROJLIB and MET_PROJINC. An update was needed to check for those values.

Expected Behavior

All of the external libraries and MET will compile successfully on machines tested.

Environment

See above descriptions

Relevant Deadlines

None

Funding Source

2702701

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@jprestop jprestop added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: bug Fix something that is not working labels Feb 26, 2025
@jprestop jprestop self-assigned this Feb 26, 2025
@jprestop jprestop added component: build process Build process issue requestor: METplus Team METplus Development Team priority: high High Priority and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 26, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1.0 Development Feb 26, 2025
@jprestop jprestop moved this from 🩺 Needs Triage to 🏗 In progress in METplus-6.1.0 Development Feb 26, 2025
@jprestop jprestop moved this from 🩺 Needs Triage to 🏗 In progress in Coordinated METplus-6.0 Support Feb 26, 2025
@jprestop jprestop moved this from 🏗 In progress to 🔎 In review in Coordinated METplus-6.0 Support Feb 27, 2025
@jprestop jprestop moved this from 🏗 In progress to 🔎 In review in METplus-6.1.0 Development Feb 27, 2025
@jprestop jprestop changed the title Bugfix: Update compilation script with dependent library compilation modifications Bugfix: Fix compilation script problems with dependent library compilations Feb 27, 2025
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Feb 27, 2025
@jprestop jprestop changed the title Bugfix: Fix compilation script problems with dependent library compilations Bugfix: Fix compilation script logic for successful dependent library compilations Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue priority: high High Priority requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
Status: 🔎 In review
Status: 🔎 In review
Development

Successfully merging a pull request may close this issue.

1 participant