Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix EE for Reliability plot increase input data count 3 times #330

Closed
23 tasks
TatianaBurek opened this issue Oct 13, 2023 · 0 comments · Fixed by #331
Closed
23 tasks

Bugfix EE for Reliability plot increase input data count 3 times #330

TatianaBurek opened this issue Oct 13, 2023 · 0 comments · Fixed by #331
Assignees
@TatianaBurek
Labels
METcalcpy: Event Equalization priority: blocker Blocker type: bug Fix something that is not working
Milestone
METcalcpy-3.0.0

Comments

@TatianaBurek
Copy link
Collaborator

Describe the Problem

Initial Reliability data doesn't have requested statistics:

  • PSTD_CALIBRATION
  • PSTD_BASER
  • PSTD_NI
    EE logic attempts to filter and equalize data for each of these statistics that results in repeating the same data 3 times - the number of requested statistics

Expected Behavior

If the data doesn't have 'fcst_var' and/or 'stat_name' in the header - perform EE logic once

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@TatianaBurek TatianaBurek added type: bug Fix something that is not working alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METcalcpy: Event Equalization labels Oct 13, 2023
@TatianaBurek TatianaBurek added this to the METcalcpy-3.0.0 milestone Oct 13, 2023
@TatianaBurek TatianaBurek self-assigned this Oct 13, 2023
@TatianaBurek TatianaBurek added priority: blocker Blocker and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 13, 2023
@TatianaBurek TatianaBurek changed the title Bugfix EE for Reliability increase input data count 3 times Bugfix EE for Reliability plot increase input data count 3 times Oct 13, 2023
@TatianaBurek TatianaBurek moved this from 🆕 New to 🏗 In progress in METplus-Analysis-6.0.0 Development Oct 13, 2023
TatianaBurek added a commit that referenced this issue Oct 13, 2023
@TatianaBurek
loop over statistics only once to avoid data multiplication #330
1ea83f8
@TatianaBurek TatianaBurek linked a pull request Oct 13, 2023 that will close this issue
loop over statistics only once to avoid data multiplication #330 #331
Merged
14 tasks
@TatianaBurek TatianaBurek moved this from 🏗 In progress to 👀 In review in METplus-Analysis-6.0.0 Development Oct 13, 2023
bikegeek pushed a commit that referenced this issue Oct 13, 2023
@TatianaBurek
loop over statistics only once to avoid data multiplication #330 (#331)
cf3dbd4
@bikegeek bikegeek moved this from 👀 In review to ✅ Done in METplus-Analysis-6.0.0 Development Oct 13, 2023
jprestop added a commit that referenced this issue Feb 2, 2024
@lisagoodrich @hankenstein2
@georgemccabe @JohnHalleyGotway @TatianaBurek @jprestop @hertneky @bikegeek
Feature 345 develop gha node20 (#347)
15d1cc0 
* Prepare for next release

* add missing end quote to fix package install

* reset_index is performed on the float value #322 (#323)

* Update release notes (#328)

* Update release-notes.rst formatting

* Update and rename 2.1.0_wcoss2 to 3.0.0_wcoss2

* loop over statistics only once to avoid data multiplication #330 (#331)

* Added sphinx_rtd_theme to extensions

* Updated requirements.txt

* Added pillow

* feature 497 headers (#336)

* changing header for continuity

* Modified the other headers in the file to be consistent with other repos

---------

Co-authored-by: Julie Prestopnik <[email protected]>

* Beta2 release (#338)

* Next version

* Feature 332 di doc (#333)

* Add difficulty index documentation

* Add more documentation

* Add more definition

* Fix indent

* Add figure

* fix indentation

* fix equations

* Add table

* Added remaining tables

* fix table issue

* Add links

* formatting

* change link to latest

---------

Co-authored-by: Tracy <[email protected]>

* Additions to beta2 release (#340)

* Next beta

* Bugfix 329 negative bcmse (#344)

* Issue #329 return 0 if negative BCMSE value is calculated

* Issue #329 add test for calculate_bcmse() in the sl1l2_statistics module

* Issue #392 added test_sl1l2.py to the list of pytests to run

* command line updates

* updating yaml file

---------

Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Tatiana Burek <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Tracy <[email protected]>
Co-authored-by: bikegeek <[email protected]>
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaBurek TatianaBurek

Labels
METcalcpy: Event Equalization priority: blocker Blocker type: bug Fix something that is not working
Projects
No open projects
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METcalcpy-3.0.0
Development

Successfully merging a pull request may close this issue.

loop over statistics only once to avoid data multiplication #330 dtcenter/METcalcpy
3 participants
@bikegeek @jprestop @TatianaBurek