Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GenVxMask wrapper to compute time-varying masks using Local Solar Time #2586

Open
2 of 23 tasks
jvigh opened this issue May 15, 2024 · 3 comments · May be fixed by #2833
Open
2 of 23 tasks

Enhance GenVxMask wrapper to compute time-varying masks using Local Solar Time #2586

jvigh opened this issue May 15, 2024 · 3 comments · May be fixed by #2833
Assignees
Labels
MET: Masking priority: blocker Blocker requestor: NOAA/SWPC NOAA Space Weather Prediction Center required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Milestone

Comments

@jvigh
Copy link
Contributor

jvigh commented May 15, 2024

Describe the New Feature

The goal of this use case is to enhance the gen_vx_mask tool to compute time-varying masks using Local Solar Time (LST).

Background: SWPC would like to be able to stratify verification results by Local Solar Time (e.g., local time, instead of UTC). Solar time is similar to azimuthal solar angle (which relates to the position of the sun), but is expressed in time rather than angle. The exact calculation of LST can be quite complex and involve computing the solar subpoint. However, the following approximate formula is usually accurate enough (+/- a few seconds or minutes) in the low and mid-latitudes.

LST_approximate = Time_UTC + Longitude_degrees/15

When the sun is at its highest point of the day, LST = 12:00 (Local Solar Noon)

Currently, there does not seem to be a way to compute and use LST in MET or the METplus analysis suite. Ideally, in the future MET and the METplus analysis suite will be modified to directly support handling LST as an auxiliary time variable, but this would require adding an extra column to all of the tools and downstream processing infrastructure. It is beyond the scope of the current issue, but should be on the radar in the strategic development roadmap.

As a workaround, this issue will involve modifying the gen_vx_mask tool to compute time-varying masks using LST.

The gen_vx_mask tool already supports solar altitude (solar_alt) and solar azimuth (solar_azi) masking by computing the solar altitude and azimuth values at each grid point for the time defined by the mask_file setting. mask_file may either be set to an explicit time string in YYYYMMDD[_HH[MMSS]] format or to a gridded data file. If set to a gridded data file, the -mask_field command line option specifies the field of data whose valid time should be used. If the -thresh command line option is not used, the raw solar altitude or azimuth value for each grid point will be written to the output. If it is used, the resulting binary mask field will be written. This option is useful when defining a day/night mask.

This issue will enhance gen_vx_mask to support a new option "-type solar_time" and provide a way to define the beginning/ending solar time to be included in the mask.

Acceptance Testing

Data are described in SWPC-RT #55
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

All work on this issue must be completed by 09/30/24 if using the account key below.

Funding Source

2784543 (NOAA SWPC/OSTI)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jvigh jvigh added type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels May 15, 2024
@jvigh jvigh added this to the METplus-6.0.0 milestone May 15, 2024
@JohnHalleyGotway
Copy link
Collaborator

Need additional discussion to figure out how to address these needs in METplus.
Recommend that @jvigh schedule a meeting to brainstorm.

@jvigh jvigh added requestor: NOAA/SWPC NOAA Space Weather Prediction Center MET: Masking and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Sep 6, 2024
@jvigh jvigh changed the title Add support to analyze and plot results in Local Solar Time enhance GenVxMask to compute time-varying masks using Local Solar Time Sep 6, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title enhance GenVxMask to compute time-varying masks using Local Solar Time Enhance Gen-Vx-Mask to compute time-varying masks using Local Solar Time Sep 6, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance Gen-Vx-Mask to compute time-varying masks using Local Solar Time Enhance GenVxMask wrapper to compute time-varying masks using Local Solar Time Sep 6, 2024
@JohnHalleyGotway
Copy link
Collaborator

Note that I have removed @JohnHalleyGotway and @bikegeek as assignees on this METplus wrapper update issue. I added @georgemccabe since he is best-suited to update the GenVxMask wrapper. I'll create a separate issue to enhance the MET gen_vx_mask tool to actually do this.

@JohnHalleyGotway JohnHalleyGotway added the required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project label Sep 6, 2024
@DanielAdriaansen DanielAdriaansen added requestor: Navy/NRL Naval Research Laboratory reporting: NRL METplus Naval Research Laboratory METplus Project and removed requestor: Navy/NRL Naval Research Laboratory reporting: NRL METplus Naval Research Laboratory METplus Project labels Oct 30, 2024
@georgemccabe georgemccabe moved this from 🟢 Ready to 🎯 Up Next in METplus-Wrappers-6.1.0 Development Nov 15, 2024
@georgemccabe
Copy link
Collaborator

Related to this work is issue dtcenter/MET#2966 and PR dtcenter/MET#3008

@georgemccabe georgemccabe moved this from 🎯 Up Next to 🏗 In progress in METplus-Wrappers-6.1.0 Development Dec 11, 2024
georgemccabe added a commit that referenced this issue Dec 13, 2024
…d line arguments that can now contain comma-separated lists that should not be split up into separate items
@georgemccabe georgemccabe linked a pull request Dec 13, 2024 that will close this issue
16 tasks
@georgemccabe georgemccabe moved this from 🏗 In progress to 🔎 In review in METplus-Wrappers-6.1.0 Development Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Masking priority: blocker Blocker requestor: NOAA/SWPC NOAA Space Weather Prediction Center required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Projects
Status: 🔎 In review
Development

Successfully merging a pull request may close this issue.

5 participants