[CI] Add Dockerfile for setting up CI runner #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtcxzyw
reviewed
Sep 30, 2024
runner-setup/Dockerfile
Outdated
| ENV RUNNER_HOME=/home/${RUNNER_USER} | ||
| # Should probably use docker compose and to set these values: | ||
| ENV RUNNER_VERSION=2.319.1 | ||
| ENV GITHUB_TOKEN=#<Github Token Here> |
There was a problem hiding this comment.
Use RUN --mount=type=secret for secrets: https://docs.docker.com/reference/dockerfile/#example-mount-as-environment-variable
There was a problem hiding this comment.
I think just ARG will work here.
runner-setup/Dockerfile
Outdated
| #RUN ./bin/installdependencies.sh | ||
|
|
||
| # Install python3 packages | ||
| RUN pip3 install tqdm --break-system-packages |
There was a problem hiding this comment.
We can install python3-tqdm with apt.
|
Updated documentation with everything thats been necessary. Think should be easily reproducible anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add future runners.
Wait on success of:
https://github.com/dtcxzyw/llvm-opt-benchmark/actions/runs/11108241699/job/30860722989?pr=1400
to make sure this is correct.