Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4.3 #339

Merged
merged 8 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: true
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.8", "3.12"]

defaults:
run:
Expand All @@ -31,7 +31,7 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: conda-incubator/setup-miniconda@v2
- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
activate-environment: test
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/pytest_cov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
fail-fast: true
matrix:
os: ["ubuntu-latest", "windows-latest"]
python-version: ["3.10"]
python-version: ["3.11"]

defaults:
run:
Expand All @@ -32,7 +32,7 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: conda-incubator/setup-miniconda@v2
- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
activate-environment: test
Expand All @@ -56,7 +56,8 @@ jobs:
run: |
pytest --cov=./ --cov-report=xml

- uses: codecov/codecov-action@v3
- uses: codecov/codecov-action@v4
with:
flags: unittests
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }} # required
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,5 @@ If **autodE** is used in a publication please consider citing the [paper](https:
- Jonathon Vandezande ([@jevandezande](https://github.com/jevandezande))
- Shoubhik Maiti ([@shoubhikraj](https://github.com/shoubhikraj))
- Daniel Hollas ([@danielhollas](https://github.com/danielhollas))
- Nils Heunemann ([@nilsheunemann](https://github.com/NilsHeunemann))
- Sijie Fu ([@sijiefu](https://github.com/SijieFu))
7 changes: 5 additions & 2 deletions autode/bracket/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def _exceeded_maximum_iteration(self) -> bool:
if self._micro_iter >= self._maxiter:
logger.error(
f"Reached the maximum number of micro-iterations "
f"*{self._maxiter}"
f"*{self._maxiter}*"
)
return True
else:
Expand Down Expand Up @@ -165,6 +165,9 @@ def _calculate(

n_cores = Config.n_cores if n_cores is None else int(n_cores)
self.imgpair.set_method_and_n_cores(method, n_cores)
self.imgpair.initialise_trj(
f"{self._name}_left_history.zip", f"{self._name}_right_history.zip"
)
self._initialise_run()

logger.info(f"Starting {self._name} method to find transition state")
Expand Down Expand Up @@ -205,7 +208,7 @@ def _calculate(
f"iterations (optimiser steps). {self._name} is "
f"{'converged' if self.converged else 'not converged'}"
)

self.imgpair.close_trj()
self.print_geometries()
self.plot_energies()
if self.converged and self.ts_guess is not None:
Expand Down
Loading
Loading