Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the java-to-rust test integration with ui_test #172

Open
bowemi opened this issue Jul 11, 2024 · 2 comments
Open

Improve the java-to-rust test integration with ui_test #172

bowemi opened this issue Jul 11, 2024 · 2 comments

Comments

@bowemi
Copy link
Contributor

bowemi commented Jul 11, 2024

Right now if you annotate a java-to-rust test with //@check-pass it also runs and if you annotate with //@run, it errors

Currently build.rs compiles all java code with javac then the java-to-rust tests are run with java via the java_wrapper

By having the java compilation separate from the java run, ui_test features that expect compilation success or failure don't work as expected.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 11, 2024

I'm releasing a new ui test version this week. We can then write a custom //@run flag to handle this correctly

@bowemi
Copy link
Contributor Author

bowemi commented Jul 11, 2024

Another option is to update java_wrapper to take in additional parameters as well as run javac + java. Then java_wrapper could use the file annotations to determine whether javac + java is used or just javac

https://github.com/duchess-rs/duchess/blob/main/test-crates/duchess-java-tests/tests/ui.rs#L131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants