Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method resolution order #79

Open
nikomatsakis opened this issue Jun 1, 2023 · 1 comment
Open

method resolution order #79

nikomatsakis opened this issue Jun 1, 2023 · 1 comment

Comments

@nikomatsakis
Copy link
Member

Both method dispatch (#73) and enum downcasting have a need to compute a "method resolution order". There is documentation in #73 suggesting we use Python's C3 algorithm, but in fact we do not. There is code for enum derive that uses a rather inefficient (but effective) algorithm to pick a good testing order. We should rework the Upcasts type to provide a proper MRO. This might be as simple as taking the code from enums, inefficient or not, I haven't thought too closely about it.

@nikomatsakis nikomatsakis added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 1, 2023
@rcoh
Copy link
Contributor

rcoh commented May 20, 2024

@nikomatsakis is this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants