Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Gitmoji standard #393

Closed
wants to merge 14 commits into from
Closed

📝 Gitmoji standard #393

wants to merge 14 commits into from

Conversation

EldaveO
Copy link

@EldaveO EldaveO commented Nov 10, 2021

Summary

📝 Addition of the gitmoji standard and creation of the contributing guidelines.
Reviewed using a markdown editor.
resolves #390

Checklist
  • this is a source code change
    • run isort . && black . in the repository root
    • run pytest in the repository root
    • link to issue being fixed using a fixes keyword, if such an issue exists
    • update the wiki documentation if necessary
  • or, this is not a source code change

@EldaveO
Create contributing_guidelines.md
2321864 
📝

Addition of the gitmoji standard and creation of the contributing guidelines
@EldaveO
Update contributing_guidelines.md
b0e494e 
Minor text changes
twentylemon
twentylemon requested changes Nov 10, 2021
View reviewed changes
Copy link
Member

@twentylemon twentylemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't even use an emoji in this pull request. Come on dude.

@EldaveO
Proper file name
df57061 
Update of the file name, and removed references to a "standard" ✏️
twentylemon
twentylemon requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@twentylemon twentylemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more about this, I don't think CONTRIBUTING is the best place for this. We don't really want contributors and likely won't refer or add to these guidelines for that reason. Adding to the existing pull request template is sufficient for fixing #390, and more likely to serve as a reminder to people opening pull requests to actually add the emojis -- hiding them in CONTRIBUTING will lead to a lot of forgotten emojis.

Also,

You didn't even use an emoji in this pull request. Come on dude.

Actually though.

@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #393 (00bfa70) into main (a6ebfd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          82       82           
  Lines        1595     1595           
  Branches      220      220           
=======================================
  Hits         1549     1549           
  Misses         37       37           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ebfd5...00bfa70. Read the comment docs.

@Chippers255
Copy link
Collaborator

bruh

You didn't even use an emoji in this pull request. Come on dude.

@Chippers255 Chippers255 changed the title Gitmoji standard 📝 Gitmoji standard Nov 11, 2021
@EldaveO
Copy link
Author

EldaveO commented Nov 11, 2021

So for PRs the emojis should be in the tile rather than in the summary section.

Lesson learned.

@twentylemon twentylemon added the needs reply PR or issue needs traction soon or it'll be discarded label Nov 25, 2021
@twentylemon
Copy link
Member

@EldaveO attaching needs reply label. Get some traction or it's getting yeeted.

@jameshughes89
Copy link
Collaborator

Thinking more about this, I don't think CONTRIBUTING is the best place for this. We don't really want contributors and likely won't refer or add to these guidelines for that reason. Adding to the existing pull request template is sufficient for fixing #390, and more likely to serve as a reminder to people opening pull requests to actually add the emojis -- hiding them in CONTRIBUTING will lead to a lot of forgotten emojis.

+1 for template.

@jameshughes89
Copy link
Collaborator

I'm still down, but for a simpler, lightweight and minimalist version.

@github-actions
Copy link

Yo dawg, get some traction on this or it'll be yeeted. Brother.

@github-actions github-actions bot added the stale Will be auto-closed if there's no activity label Jan 24, 2022
@EldaveO
Copy link
Author

EldaveO commented Jan 24, 2022 via email

@github-actions github-actions bot removed stale Will be auto-closed if there's no activity needs reply PR or issue needs traction soon or it'll be discarded labels Jan 31, 2022
@twentylemon twentylemon added the needs reply PR or issue needs traction soon or it'll be discarded label Jan 31, 2022
@twentylemon twentylemon added the stale Will be auto-closed if there's no activity label Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

YEET

@github-actions github-actions bot closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twentylemon twentylemon twentylemon requested changes

Assignees
No one assigned
Labels
needs reply PR or issue needs traction soon or it'll be discarded stale Will be auto-closed if there's no activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start using gitmojis
4 participants
@EldaveO @Chippers255 @twentylemon @jameshughes89