Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove markdown before checking if a message is a haiku #669

Open
twentylemon opened this issue Jan 8, 2023 · 2 comments
Open

remove markdown before checking if a message is a haiku #669

twentylemon opened this issue Jan 8, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@twentylemon
Copy link
Member

Title. We currently remove a hardcoded list of symbols from the message, but we should also clean up markdown as well.

Discord.py's remove_markdown might be useful.

@twentylemon twentylemon added bug Something isn't working good first issue Good for newcomers labels Jan 8, 2023
@jameshughes89
Copy link
Collaborator

Mildly-ish related to #525

@twentylemon
Copy link
Member Author

Yes and no. Though we remove punctuation when checking if a message is a haiku, we keep that punctuation when producing the resultant message. So like three, two seven, two three (words being the number of syllables they are would give:

three, two
seven,
two three

We essentially remove the punctuation so we can lookup how many syllables a word is. So a message like three **two** _seven two_ three should yield:

three two
seven
two three

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants