Set other onboarding_experiment_background backgrounds in ImageViews

duckduckgo · Aug 12, 2024 · 159106f · 159106f
1 parent 53e0b0f
commit 159106f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
@@ -3883,8 +3883,6 @@ class BrowserTabFragment :
             }
             newBrowserTab.newTabLayout.setOnClickListener { daxDialogIntroBubbleCta.dialogTextCta.finishAnimation() }
 
-            newBrowserTab.browserBackground.setBackgroundResource(R.drawable.onboarding_experiment_background)
-
             viewModel.onCtaShown()
         }
 
@@ -3905,8 +3903,6 @@ class BrowserTabFragment :
                     viewModel.onUserClickCtaOkButton(configuration)
                 }
             }
-            binding.includeOnboardingDaxDialog.onboardingDaxDialogBackground
-                .setBackgroundResource(R.drawable.onboarding_experiment_background)
             binding.webViewContainer.setOnClickListener { daxDialogIntroBubbleCta.dialogTextCta.finishAnimation() }
             viewModel.onCtaShown()
         }

diff --git a/app/src/main/res/layout/include_new_browser_tab.xml b/app/src/main/res/layout/include_new_browser_tab.xml
@@ -32,6 +32,16 @@
         android:paddingTop="?attr/actionBarSize"
         android:foreground="@android:color/transparent">
 
+        <ImageView
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            android:scaleType="centerCrop"
+            app:srcCompat="@drawable/onboarding_experiment_background" />
+
         <FrameLayout
             android:id="@+id/newTabContainerLayout"
             android:layout_width="match_parent"

diff --git a/app/src/main/res/layout/include_onboarding_view_dax_dialog.xml b/app/src/main/res/layout/include_onboarding_view_dax_dialog.xml
@@ -28,9 +28,18 @@
         android:id="@+id/onboardingDaxDialogBackground"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        tools:background="@drawable/onboarding_experiment_background"
         android:clipChildren="false">
 
+        <ImageView
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            android:scaleType="centerCrop"
+            app:srcCompat="@drawable/onboarding_experiment_background" />
+
         <androidx.appcompat.widget.AppCompatImageView
             android:id="@+id/logo"
             android:layout_width="56dp"