Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocklist feature and enable aa baseline experiment on Android #2523

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marcosholgado
Copy link
Contributor

Asana Task/Github Issue:
https://app.asana.com/0/72649045549333/1208853432481435/f

Description

This PR adds a new blocklist feature and enables the first a/a experiment on Android

Reference

@marcosholgado marcosholgado requested review from a team as code owners November 27, 2024 15:44
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

@marcosholgado marcosholgado added the DO NOT MERGE Don't merge this branch unless directed label Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Generated file outputs:

Time updated: Wed, 27 Nov 2024 15:58:50 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -1708,8 +1708,32 @@
                     "state": "enabled"
                 }
             }
         },
+        "blockList": {
+            "state": "enabled",
+            "exceptions": [],
+            "features": {
+                "tdsNextExperimentBaseline": {
+                    "state": "enabled",
+                    "minSupportedVersion": 52200000,
+                    "settings": {
+                        "controlUrl": "temp/android-experiment-tds.json",
+                        "treatmentUrl": "temp/android-experiment-tds.json"
+                    },
+                    "cohorts": [
+                        {
+                            "name": "control",
+                            "weight": 1
+                        },
+                        {
+                            "name": "treatment",
+                            "weight": 1
+                        }
+                    ]
+                }
+            }
+        },
         "bookmarks": {
             "state": "enabled",
             "exceptions": []
         },
v3/extension-brave-config.json (12 more)
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -798,8 +798,12 @@
                     "state": "enabled"
                 }
             }
         },
+        "blockList": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "bookmarks": {
             "state": "enabled",
             "exceptions": [],
             "features": {
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -1544,8 +1544,32 @@
                     "state": "enabled"
                 }
             }
         },
+        "blockList": {
+            "state": "enabled",
+            "exceptions": [],
+            "features": {
+                "tdsNextExperimentBaseline": {
+                    "state": "enabled",
+                    "minSupportedVersion": 52200000,
+                    "settings": {
+                        "controlUrl": "temp/android-experiment-tds.json",
+                        "treatmentUrl": "temp/android-experiment-tds.json"
+                    },
+                    "cohorts": [
+                        {
+                            "name": "control",
+                            "weight": 1
+                        },
+                        {
+                            "name": "treatment",
+                            "weight": 1
+                        }
+                    ]
+                }
+            }
+        },
         "bookmarks": {
             "state": "enabled",
             "exceptions": []
         },
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -639,8 +639,12 @@
                     "state": "enabled"
                 }
             }
         },
+        "blockList": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "bookmarks": {
             "state": "enabled",
             "exceptions": [],
             "features": {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants