Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Report for Windows and Android #251

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Toggle Report for Windows and Android #251

merged 12 commits into from
Nov 29, 2024

Conversation

mgurgel
Copy link
Collaborator

@mgurgel mgurgel commented Nov 27, 2024

Asana: https://app.asana.com/0/1163321984198618/1208865759492772/f

Reviewer: @shakyShane

Description:

This extracts the Toggle Report changes from #196 to unblock Windows and Android development

Steps to test this PR:

  1. Download a demo build <Windows | Android TBC> or visit the preview page
  2. Invoke the Toggle Report screen

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for ddgdash ready!

Name Link
🔨 Latest commit f83ff1d
🔍 Latest deploy log https://app.netlify.com/sites/ddgdash/deploys/6749e32f20f2a8000828369f
😎 Deploy Preview https://deploy-preview-251--ddgdash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 27, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

NPM

npm i github:duckduckgo/privacy-dashboard#08293cce410525b0e3de089510c7df399a2610a6

Git submodule:

git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227

Swift

.package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "08293cce410525b0e3de089510c7df399a2610a6"),

@mgurgel mgurgel self-assigned this Nov 27, 2024
@mgurgel mgurgel changed the title [WIP] Toggle Report for Windows and Android Toggle Report for Windows and Android Nov 28, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to change the copy within this PR?

@mgurgel mgurgel merged commit e1ec133 into main Nov 29, 2024
8 checks passed
@mgurgel mgurgel deleted the mgurgel/toggle-report branch November 29, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants