Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the master as a zk:// uri #34

Open
SEJeff opened this issue Aug 20, 2015 · 6 comments
Open

Allow specifying the master as a zk:// uri #34

SEJeff opened this issue Aug 20, 2015 · 6 comments

Comments

@SEJeff
Copy link

SEJeff commented Aug 20, 2015

It is more web scale that way.

@tarnfeld
Copy link
Contributor

Currently portainer uses the pure-python implementation of the Mesos framework APIs (pesos) and we're still working on bringing stable zookeeper master detection and failover to that library. The use of pesos allows us to avoid requiring libmesos for the scheduler and executor, but with the upcoming HTTP API the landscape is changing quite a bit.

Though yes, it's definitely something that we should focus on implementing.. perhaps that means switching back to libmesos on the scheduler side to gain the benefits of zookeeper master detection.

@SEJeff
Copy link
Author

SEJeff commented Aug 20, 2015

Just use kazoo and setup a watch on the (default, but configurable) /mesos znode. It shouldn't be that hard, right? :)

@tarnfeld
Copy link
Contributor

It's not that it's hard, it's that we've just not done it yet ;) You're more than welcome to submit a patch to pesos, or a patch to switch to libmesos, that'd be awesome!

@SEJeff
Copy link
Author

SEJeff commented Aug 31, 2015

No expert in pesos (yet), but from a 2 minute scan of the code in the github ui, PesosSchedulerDriver led me to MasterDetector, which led me here. I wanted to see how hard it would be to add, but the design is perfectly abstract to make something like this relatively straightforward.

Is it possible that pesos has added support for a ZK uri as the master_uri and you didn't realize it yet? Looks like it supports it pretty clearly to me unless I'm obviously missing something, if so then I guess yay!

@tarnfeld
Copy link
Contributor

Yep, pesos does indeed have some rudimentary ZK support however it's not very stable. I PRd some patches (wickman/pesos#19) around the code but admittedly didn't have the time to fully test it out, if I remember correctly there were still a few gaps in the implementation.

Let me know if you give it a try out! My expectation is that pesos will either be replaced, or refactored given the new HTTP API coming very soon.

@SEJeff
Copy link
Author

SEJeff commented Aug 31, 2015

Awesome, thanks!

Oh and the talk about MesosCon on portainer was really good. Big fan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants