Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of .dockerignore files #41

Open
orls opened this issue Sep 13, 2015 · 0 comments
Open

Incorrect handling of .dockerignore files #41

orls opened this issue Sep 13, 2015 · 0 comments
Labels

Comments

@orls
Copy link
Contributor

orls commented Sep 13, 2015

Currently, portainer only handles .dockerignore files inside directories that are being ADD/COPY'd, and does so recursively.

However, that's not the correct behaviour for dockerfiles according to the docs – there should be just one dockerignore in the root path of the build (essentially, next to the Dockerfile).

Dockerignores are an important weapon against bloat – both in the size of layers, and the time that can be saved shipping around potentially massive context that aren't wanted (.git directories, for example)

While we're at it, we should probably check how well python's fnmatch compares to Go's filepath.match and docker's additional gitignore-esque ! for exclusions, too, make sure we're correctly handling .dockerignore content, too...at a glance, I'm not sure exclusions are well-handled

@orls orls added the bug label Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant