Merge pull request #1 from duhaime/hashband-strings

store hashband keys as strings
duhaime · Mar 14, 2018 · 1a257cd · 1a257cd
2 parents d88af09 + ce66f89
commit 1a257cd
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/minhash.min.js b/minhash.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minhash",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "description": "Find similar documents quickly",
   "main": "index.js",
   "scripts": {

diff --git a/src/lsh.js b/src/lsh.js
@@ -40,7 +40,7 @@ var LshIndex = function(args) {
       var start = i * this.bandSize;
       var end = start + this.bandSize;
       var band = minhash.hashvalues.slice(start, end);
-      minhash.hashbands.push(band);
+      minhash.hashbands.push(band.join('.'));
     };
     return minhash.hashbands;
   };

diff --git a/src/minhash.js b/src/minhash.js
@@ -85,7 +85,6 @@ var Minhash = function(config) {
   var config = config || {};
   this.numPerm = config.numPerm || 128;
   this.seed = config.seed || 1;
-  this.hashFunctions = [];
   this.hashvalues = [];
   this.permA = [];
   this.permB = [];

diff --git a/tests/test-lsh.js b/tests/test-lsh.js
@@ -41,7 +41,7 @@ describe('LshIndex', function() {
       var m1 = new Minhash();
       var index = new LshIndex({bandSize: 3});
       index.insert('m1', m1);
-      (m1.hashbands[0].length === 3).should.equal(true);
+      (m1.hashbands[0].split('.').length === 3).should.equal(true);
     })
   });
 })