From 06340a68fc92611ea342d01f3e4e60f5bc78f335 Mon Sep 17 00:00:00 2001 From: Nazar Ilamanov Date: Fri, 24 Jan 2025 09:10:04 -0800 Subject: [PATCH] don't throw an error for invalid addresses --- __tests__/hooks/useEvmTokenBalances.test.tsx | 4 ++-- __tests__/hooks/useEvmTransactions.test.tsx | 4 ++-- __tests__/hooks/useSvmTokenBalances.test.tsx | 2 +- __tests__/hooks/useSvmTransactions.test.tsx | 2 +- src/evm/useEvmTokenBalances.ts | 12 +----------- src/evm/useEvmTransactions.ts | 12 +----------- src/svm/useSvmTokenBalances.ts | 12 +----------- src/svm/useSvmTransactions.ts | 12 +----------- 8 files changed, 10 insertions(+), 50 deletions(-) diff --git a/__tests__/hooks/useEvmTokenBalances.test.tsx b/__tests__/hooks/useEvmTokenBalances.test.tsx index 73188d8..955103b 100644 --- a/__tests__/hooks/useEvmTokenBalances.test.tsx +++ b/__tests__/hooks/useEvmTokenBalances.test.tsx @@ -31,7 +31,7 @@ describe("useTokenBalances", () => { expect(result.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], @@ -145,7 +145,7 @@ describe("useTokenBalances", () => { expect(mockFetchEvmBalances).not.toHaveBeenCalled(); expect(result.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], diff --git a/__tests__/hooks/useEvmTransactions.test.tsx b/__tests__/hooks/useEvmTransactions.test.tsx index 8b53c90..0280884 100644 --- a/__tests__/hooks/useEvmTransactions.test.tsx +++ b/__tests__/hooks/useEvmTransactions.test.tsx @@ -31,7 +31,7 @@ describe("useTransactions", () => { expect(result.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], @@ -217,7 +217,7 @@ describe("useTransactions", () => { expect(mockFetchEvmTransactions).not.toHaveBeenCalled(); expect(result.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], diff --git a/__tests__/hooks/useSvmTokenBalances.test.tsx b/__tests__/hooks/useSvmTokenBalances.test.tsx index da9a42b..f8cb022 100644 --- a/__tests__/hooks/useSvmTokenBalances.test.tsx +++ b/__tests__/hooks/useSvmTokenBalances.test.tsx @@ -141,7 +141,7 @@ describe("useTokenBalances", () => { expect(mockFetchSvmBalances).not.toHaveBeenCalled(); expect(svmResult.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], diff --git a/__tests__/hooks/useSvmTransactions.test.tsx b/__tests__/hooks/useSvmTransactions.test.tsx index d709476..dd10202 100644 --- a/__tests__/hooks/useSvmTransactions.test.tsx +++ b/__tests__/hooks/useSvmTransactions.test.tsx @@ -215,7 +215,7 @@ describe("useTransactions", () => { expect(mockFetchSvmTransactions).not.toHaveBeenCalled(); expect(svmResult.current).toEqual({ data: null, - error: new Error("walletAddress must be a valid address"), + error: null, isLoading: false, nextOffset: null, offsets: [], diff --git a/src/evm/useEvmTokenBalances.ts b/src/evm/useEvmTokenBalances.ts index b36b9c0..9321a55 100644 --- a/src/evm/useEvmTokenBalances.ts +++ b/src/evm/useEvmTokenBalances.ts @@ -44,17 +44,7 @@ export const useEvmTokenBalances = ( return; } - if (!walletAddress || !isAddress(walletAddress)) { - setState({ - data: null, - error: new Error("walletAddress must be a valid address"), - isLoading: false, - nextOffset: null, - offsets: [], - currentPage: 0, - }); - return; - } + if (!walletAddress || !isAddress(walletAddress)) return; setState((prevState) => ({ ...prevState, isLoading: true })); diff --git a/src/evm/useEvmTransactions.ts b/src/evm/useEvmTransactions.ts index 893b1c5..2a55b17 100644 --- a/src/evm/useEvmTransactions.ts +++ b/src/evm/useEvmTransactions.ts @@ -44,17 +44,7 @@ export const useEvmTransactions = ( return; } - if (!walletAddress || !isAddress(walletAddress)) { - setState({ - data: null, - error: new Error("walletAddress must be a valid address"), - isLoading: false, - nextOffset: null, - offsets: [], - currentPage: 0, - }); - return; - } + if (!walletAddress || !isAddress(walletAddress)) return; setState((prevState) => ({ ...prevState, isLoading: true })); diff --git a/src/svm/useSvmTokenBalances.ts b/src/svm/useSvmTokenBalances.ts index 10f08ba..0ea6935 100644 --- a/src/svm/useSvmTokenBalances.ts +++ b/src/svm/useSvmTokenBalances.ts @@ -43,17 +43,7 @@ export const useSvmTokenBalances = ( return; } - if (!walletAddress) { - setState({ - data: null, - error: new Error("walletAddress must be a valid address"), - isLoading: false, - nextOffset: null, - offsets: [], - currentPage: 0, - }); - return; - } + if (!walletAddress) return; setState((prevState) => ({ ...prevState, isLoading: true })); diff --git a/src/svm/useSvmTransactions.ts b/src/svm/useSvmTransactions.ts index 2175763..be502f8 100644 --- a/src/svm/useSvmTransactions.ts +++ b/src/svm/useSvmTransactions.ts @@ -43,17 +43,7 @@ export const useSvmTransactions = ( return; } - if (!walletAddress) { - setState({ - data: null, - error: new Error("walletAddress must be a valid address"), - isLoading: false, - nextOffset: null, - offsets: [], - currentPage: 0, - }); - return; - } + if (!walletAddress) return; setState((prevState) => ({ ...prevState, isLoading: true }));