Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cex addresses #7302

Merged
merged 3 commits into from
Jan 3, 2025
Merged

add cex addresses #7302

merged 3 commits into from
Jan 3, 2025

Conversation

hildobby
Copy link
Collaborator

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]

quick links for more information:

@hildobby hildobby added easy WIP work in progress labels Dec 11, 2024
@jeff-dude jeff-dude added the dbt: hourly covers the hourly dbt subproject label Dec 12, 2024
@jeff-dude
Copy link
Member

as usual, we will wait for you to remove WIP tag :)
for this one, be sure to tag @0xRobin when ready, as i'll be offline for a bit

@0xRobin 0xRobin self-assigned this Dec 20, 2024
@0xRobin 0xRobin marked this pull request as draft December 20, 2024 09:48
@hildobby hildobby added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 2, 2025
@hildobby hildobby marked this pull request as ready for review January 2, 2025 10:50
@hildobby hildobby requested a review from 0xRobin January 2, 2025 10:51
jeff-dude
jeff-dude approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good.

note for myself / rob:
the downstream cex flows spells are heavy, will need to scale cluster when merging here.

@jeff-dude jeff-dude added ready-for-merging and removed easy ready-for-review this PR development is complete, please review labels Jan 2, 2025
@jeff-dude jeff-dude self-assigned this Jan 2, 2025
@jeff-dude jeff-dude merged commit 62b074d into duneanalytics:main Jan 3, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

@0xRobin 0xRobin Awaiting requested review from 0xRobin

Assignees

@0xRobin 0xRobin

@jeff-dude jeff-dude

Labels
dbt: hourly covers the hourly dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hildobby @jeff-dude @0xRobin