Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic proxy configuration #222

Open
ramonpetgrave64 opened this issue May 23, 2023 · 2 comments
Open

Automatic proxy configuration #222

ramonpetgrave64 opened this issue May 23, 2023 · 2 comments

Comments

@ramonpetgrave64
Copy link

Hello from lyft/cartography!

We're using the duo client and realized that it doens't automatically use the HTTP_PROXY environment variable.
We've been using your provided method set_proxy, but it would be nice to have this be automatic, like the examples below.

@AaronAtDuo
Copy link
Contributor

@ramonpetgrave64 Thanks for the suggestion. We'll consider it, but it would have to wait for a major version release since I think this would count as a backwards-incompatible change.

@ramonpetgrave64
Copy link
Author

@AaronAtDuo Thanks for the reply. Alright. In the mean time, you could introduce an optional switch, like use_proxy_env_variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants