Merge pull request #3492 from dusk-network/simplify-serde

core: simplified serde implementations
dusk-network · Feb 14, 2025 · 90587e2 · 90587e2
2 parents bca9a01 + 34179fc
commit 90587e2
Show file tree

Hide file tree

Showing 4 changed files with 141 additions and 824 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
@@ -15,8 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Add `METADATA::PUBLIC_SENDER` [#3341]
 - Add `abi::public_sender` host fn [#3341]
-- Add serde implementations for `StakeEvent`, `SlashEvent`, `Reward`, `WithdrawEvent`, `ConvertEvent`, `DepositEvent`,
-`ContractToContractEvent`, `ContractToAccountEvent`, `PhoenixTransactionEvent` and `MoonlightTransactionEvent`
+- Add serde feature for event serialization [#2773]
 
 ## [1.0.0] - 2025-01-23
 
@@ -34,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 <!-- Issues -->
 [#3405]: https://github.com/dusk-network/rusk/issues/3405
 [#3341]: https://github.com/dusk-network/rusk/issues/3341
+[#2773]: https://github.com/dusk-network/rusk/issues/2773
 
 [Unreleased]: https://github.com/dusk-network/rusk/compare/dusk-core-1.0.0...HEAD
 [1.0.0]: https://github.com/dusk-network/rusk/compare/dusk-core-0.1.0...dusk-core-1.0.0

diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -34,7 +34,7 @@ ark-serialize = { workspace = true, optional = true }
 
 # serde support dependencies
 serde = { workspace = true, features = ["derive"], optional = true }
-base64 = { workspace = true, optional = true }
+hex = { workspace = true, optional = true }
 
 [dev-dependencies]
 rand = { workspace = true, features = ["std", "std_rng"] }
@@ -75,7 +75,7 @@ std = ["dusk-plonk/std"]
 
 serde = [
     "dep:serde",
-    "base64",
+    "hex",
     "piecrust-uplink/serde",
     "bls12_381-bls/serde",
     "phoenix-core/serde",