Skip to content

Commit

Permalink
[front] - refactor: update IconButton variant from ghost to outline (#…
Browse files Browse the repository at this point in the history
…8597)

- Change the IconButton component variant in various columns across the application for consistency and styling purposes
 - The variant was updated on sorting buttons and action buttons to maintain a uniform look throughout the platform
  • Loading branch information
JulesBelveze authored Nov 12, 2024
1 parent fbf9785 commit 36f1431
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 13 deletions.
6 changes: 3 additions & 3 deletions front/components/poke/assistants/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function makeColumnsForAssistants(
<div className="flex space-x-2">
<p>Id</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand All @@ -58,7 +58,7 @@ export function makeColumnsForAssistants(
<div className="flex space-x-2">
<p>Name</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down Expand Up @@ -100,7 +100,7 @@ export function makeColumnsForAssistants(
assistant.status !== "archived" ? TrashIcon : EmotionLaughIcon
}
size="xs"
variant="ghost"
variant="outline"
onClick={async () => {
await (assistant.status !== "archived"
? archiveAssistant(owner, reload, assistant)
Expand Down
4 changes: 2 additions & 2 deletions front/components/poke/data_source_views/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function makeColumnsForDataSourceViews(): ColumnDef<DataSourceView>[] {
<div className="flex space-x-2">
<p>sId</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand All @@ -52,7 +52,7 @@ export function makeColumnsForDataSourceViews(): ColumnDef<DataSourceView>[] {
<div className="flex space-x-2">
<p>Data Source</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down
4 changes: 2 additions & 2 deletions front/components/poke/data_sources/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function makeColumnsForDataSources(
<div className="flex space-x-2">
<p>sId</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand All @@ -52,7 +52,7 @@ export function makeColumnsForDataSources(
<div className="flex space-x-2">
<p>Name</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down
2 changes: 1 addition & 1 deletion front/components/poke/features/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function makeColumnsForFeatureFlags(
<div className="flex space-x-2">
<p>Name</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down
3 changes: 2 additions & 1 deletion front/components/poke/invitations/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function makeColumnsForInvitations(
&nbsp;
<IconButton
icon={ClipboardIcon}
variant="outline"
tooltip="Copy invite link to clipboard"
size="xs"
onClick={() =>
Expand Down Expand Up @@ -74,7 +75,7 @@ export function makeColumnsForInvitations(
<IconButton
icon={TrashIcon}
size="xs"
variant="ghost"
variant="outline"
onClick={async () => {
await onRevokeInvitation(invitation.inviteEmail);
}}
Expand Down
8 changes: 4 additions & 4 deletions front/components/poke/members/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function makeColumnsForMembers({
<div className="flex space-x-2">
<p>Id</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand All @@ -50,7 +50,7 @@ export function makeColumnsForMembers({
<div className="flex space-x-2">
<p>Name</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down Expand Up @@ -88,7 +88,7 @@ export function makeColumnsForMembers({
<div className="flex space-x-2">
<p>Role</p>
<IconButton
variant="ghost"
variant="outline"
icon={ArrowsUpDownIcon}
onClick={() =>
column.toggleSorting(column.getIsSorted() === "asc")
Expand Down Expand Up @@ -134,7 +134,7 @@ export function makeColumnsForMembers({
<IconButton
icon={TrashIcon}
size="xs"
variant="ghost"
variant="outline"
onClick={async () => {
await onRevokeMember(member);
}}
Expand Down

0 comments on commit 36f1431

Please sign in to comment.