Make use of Temporal/executeChild type safe (#1178)

dust-tt · Aug 31, 2023 · 43c53e5 · 43c53e5
1 parent 27d2325
commit 43c53e5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/connectors/src/connectors/github/temporal/workflows.ts b/connectors/src/connectors/github/temporal/workflows.ts
@@ -75,7 +75,7 @@ export async function githubFullSyncWorkflow(
       const childWorkflowId = `${fullSyncWorkflowId}-repo-${repo.id}`;
       promises.push(
         queue.add(() =>
-          executeChild(githubRepoSyncWorkflow.name, {
+          executeChild(githubRepoSyncWorkflow, {
             workflowId: childWorkflowId,
             args: [
               dataSourceConfig,
@@ -110,7 +110,7 @@ export async function githubReposSyncWorkflow(
     const childWorkflowId = `${reposSyncWorkflowId}-repo-${repo.id}`;
     promises.push(
       queue.add(() =>
-        executeChild(githubRepoSyncWorkflow.name, {
+        executeChild(githubRepoSyncWorkflow, {
           workflowId: childWorkflowId,
           args: [
             dataSourceConfig,

diff --git a/connectors/src/connectors/google_drive/temporal/workflows.ts b/connectors/src/connectors/google_drive/temporal/workflows.ts
@@ -94,7 +94,7 @@ export async function googleDriveFullSync(
   await syncSucceeded(connectorId);
 
   if (garbageCollect) {
-    await executeChild(googleDriveGarbageCollectorWorkflow.name, {
+    await executeChild(googleDriveGarbageCollectorWorkflow, {
       workflowId: googleDriveGarbageCollectorWorkflowId(connectorId),
       args: [connectorId, startSyncTs],
     });

diff --git a/connectors/src/connectors/notion/temporal/workflows.ts b/connectors/src/connectors/notion/temporal/workflows.ts
@@ -158,7 +158,7 @@ export async function notionSyncWorkflow(
           }`;
           promises.push(
             childWorkflowQueue.add(() =>
-              executeChild(notionSyncResultPageWorkflow.name, {
+              executeChild(notionSyncResultPageWorkflow, {
                 workflowId,
                 args: [
                   dataSourceConfig,
@@ -193,7 +193,7 @@ export async function notionSyncWorkflow(
           }`;
           promises.push(
             childWorkflowQueue.add(() =>
-              executeChild(notionSyncResultPageDatabaseWorkflow.name, {
+              executeChild(notionSyncResultPageDatabaseWorkflow, {
                 workflowId,
                 args: [
                   dataSourceConfig,

diff --git a/connectors/src/connectors/slack/temporal/workflows.ts b/connectors/src/connectors/slack/temporal/workflows.ts
@@ -55,10 +55,10 @@ export async function workspaceFullSync(
   const channels = await getChannels(slackAccessToken);
   let i = 0;
   for (const channel of channels) {
-    if (!channel.id) {
+    if (!channel.id || !channel.name) {
       throw new Error(`Channel ${channel.name} has no id`);
     }
-    await executeChild(syncOneChannel.name, {
+    await executeChild(syncOneChannel, {
       workflowId: syncOneChanneWorkflowlId(connectorId, channel.id),
       args: [
         connectorId,