Skip to content

Commit

Permalink
Fixing padding error (#9656)
Browse files Browse the repository at this point in the history
* Fixing padding error

* zIndex problem fix
:q

* Update front/components/sparkle/AppLayout.tsx

Co-authored-by: Thomas Draier <[email protected]>

* patch

* Remove default value

---------

Co-authored-by: Thomas Draier <[email protected]>
  • Loading branch information
Duncid and tdraier authored Dec 30, 2024
1 parent 786a402 commit 5eb0f09
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
7 changes: 6 additions & 1 deletion front/components/sparkle/AppLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default function AppLayout({
pageTitle,
navChildren,
titleChildren,
hasTopPadding,
children,
}: {
owner: WorkspaceType;
Expand All @@ -47,6 +48,7 @@ export default function AppLayout({
navChildren?: React.ReactNode;
titleChildren?: React.ReactNode;
children: React.ReactNode;
hasTopPadding?: boolean;
}) {
const [loaded, setLoaded] = useState(false);

Expand Down Expand Up @@ -124,7 +126,10 @@ export default function AppLayout({
<div className="relative h-full w-full flex-1 flex-col overflow-x-hidden overflow-y-hidden">
<main
id={CONVERSATION_PARENT_SCROLL_DIV_ID.page}
className="flex h-full w-full flex-col items-center"
className={classNames(
"flex h-full w-full flex-col items-center overflow-y-auto",
hasTopPadding ?? !titleChildren ? "lg:pt-8" : ""
)}
>
<div
className={classNames(
Expand Down
4 changes: 2 additions & 2 deletions sparkle/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sparkle/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dust-tt/sparkle",
"version": "0.2.348",
"version": "0.2.349",
"scripts": {
"build": "rm -rf dist && npm run tailwind && npm run build:esm && npm run build:cjs",
"tailwind": "tailwindcss -i ./src/styles/tailwind.css -o dist/sparkle.css",
Expand Down
2 changes: 1 addition & 1 deletion sparkle/src/components/NavigationList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ const variantStyles = cva("", {
secondary: "s-text-muted-foreground",
},
isSticky: {
true: "s-sticky s-top-0 s-z-50 s-border-b s-border-border-dark/80 s-bg-structure-100/90 s-backdrop-blur-sm",
true: "s-sticky s-top-0 s-z-10 s-border-b s-border-border-dark/80 s-bg-structure-100/90 s-backdrop-blur-sm",
},
},
defaultVariants: {
Expand Down

0 comments on commit 5eb0f09

Please sign in to comment.