Skip to content

Commit

Permalink
Feedback selector warns about conversatin sharing (#9238)
Browse files Browse the repository at this point in the history
* Feedback selector warns about conversatin sharing

* Removed warning about conversation being shared

---------

Co-authored-by: Lucas <[email protected]>
  • Loading branch information
overmode and overmode authored Dec 10, 2024
1 parent 3c50cad commit 7308add
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions sparkle/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sparkle/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dust-tt/sparkle",
"version": "0.2.336",
"version": "0.2.337",
"scripts": {
"build": "rm -rf dist && npm run tailwind && npm run build:esm && npm run build:cjs",
"tailwind": "tailwindcss -i ./src/styles/tailwind.css -o dist/sparkle.css",
Expand Down
12 changes: 6 additions & 6 deletions sparkle/src/components/FeedbackSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ export function FeedbackSelector({
? "🎉 Glad you liked it! Tell us more?"
: "🫠 Help make the answers better!"}
</Page.H>
{popOverInfo}
<TextArea
placeholder={
feedback?.thumb === "up"
Expand All @@ -135,7 +134,13 @@ export function FeedbackSelector({
value={localFeedbackContent ?? ""}
onChange={(e) => setLocalFeedbackContent(e.target.value)}
/>
{popOverInfo}
<div className="s-mt-4 s-flex s-justify-between s-gap-2">
<Button
variant="ghost"
label="Skip"
onClick={() => setIsPopoverOpen(false)}
/>
<Button
variant="primary"
label="Submit feedback"
Expand All @@ -148,11 +153,6 @@ export function FeedbackSelector({
setIsPopoverOpen(false);
}}
/>
<Button
variant="ghost"
label="Skip"
onClick={() => setIsPopoverOpen(false)}
/>
</div>
</div>
)}
Expand Down

0 comments on commit 7308add

Please sign in to comment.