From 7308add1aa2802fe8331566b763c1c379789df71 Mon Sep 17 00:00:00 2001
From: Lucas Massemin <lucasmassemin@gmail.com>
Date: Tue, 10 Dec 2024 11:22:37 +0100
Subject: [PATCH] Feedback selector warns about conversatin sharing (#9238)

* Feedback selector warns about conversatin sharing

* Removed warning about conversation being shared

---------

Co-authored-by: Lucas <lucas@dust.tt>
---
 sparkle/package-lock.json                   |  4 ++--
 sparkle/package.json                        |  2 +-
 sparkle/src/components/FeedbackSelector.tsx | 12 ++++++------
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/sparkle/package-lock.json b/sparkle/package-lock.json
index c213f4bfdf15..e4460a0a45ca 100644
--- a/sparkle/package-lock.json
+++ b/sparkle/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "@dust-tt/sparkle",
-  "version": "0.2.336",
+  "version": "0.2.337",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@dust-tt/sparkle",
-      "version": "0.2.336",
+      "version": "0.2.337",
       "license": "ISC",
       "dependencies": {
         "@emoji-mart/data": "^1.1.2",
diff --git a/sparkle/package.json b/sparkle/package.json
index 2467f320980e..6117396001de 100644
--- a/sparkle/package.json
+++ b/sparkle/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dust-tt/sparkle",
-  "version": "0.2.336",
+  "version": "0.2.337",
   "scripts": {
     "build": "rm -rf dist && npm run tailwind && npm run build:esm && npm run build:cjs",
     "tailwind": "tailwindcss -i ./src/styles/tailwind.css -o dist/sparkle.css",
diff --git a/sparkle/src/components/FeedbackSelector.tsx b/sparkle/src/components/FeedbackSelector.tsx
index c4bdac65f7a3..6713200e56c8 100644
--- a/sparkle/src/components/FeedbackSelector.tsx
+++ b/sparkle/src/components/FeedbackSelector.tsx
@@ -123,7 +123,6 @@ export function FeedbackSelector({
                   ? "🎉 Glad you liked it! Tell us more?"
                   : "🫠 Help make the answers better!"}
               </Page.H>
-              {popOverInfo}
               <TextArea
                 placeholder={
                   feedback?.thumb === "up"
@@ -135,7 +134,13 @@ export function FeedbackSelector({
                 value={localFeedbackContent ?? ""}
                 onChange={(e) => setLocalFeedbackContent(e.target.value)}
               />
+              {popOverInfo}
               <div className="s-mt-4 s-flex s-justify-between s-gap-2">
+                <Button
+                  variant="ghost"
+                  label="Skip"
+                  onClick={() => setIsPopoverOpen(false)}
+                />
                 <Button
                   variant="primary"
                   label="Submit feedback"
@@ -148,11 +153,6 @@ export function FeedbackSelector({
                     setIsPopoverOpen(false);
                   }}
                 />
-                <Button
-                  variant="ghost"
-                  label="Skip"
-                  onClick={() => setIsPopoverOpen(false)}
-                />
               </div>
             </div>
           )}