fix: deadlock in notion getParents (#8813)

Co-authored-by: Henry Fontanier <[email protected]>
dust-tt · Nov 21, 2024 · 8afd6bb · 8afd6bb
1 parent b6a9b2b
commit 8afd6bb
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/connectors/src/connectors/notion/lib/parents.ts b/connectors/src/connectors/notion/lib/parents.ts
@@ -64,29 +64,29 @@ async function _getParents(
       return parents;
     case "page":
     case "database": {
-      if (seen.includes(pageOrDbId)) {
+      seen.push(pageOrDbId);
+      if (!pageOrDb.parentId) {
         logger.error(
           {
             connectorId,
             pageOrDbId,
-            seen,
             parentId: pageOrDb.parentId,
           },
-          "getParents infinite loop"
+          "getParents parentId is undefined"
         );
-        return parents.concat(seen);
+        throw new Error("getParent parentId is undefined");
       }
-      seen.push(pageOrDbId);
-      if (!pageOrDb.parentId) {
+      if (seen.includes(pageOrDb.parentId)) {
         logger.error(
           {
             connectorId,
             pageOrDbId,
+            seen,
             parentId: pageOrDb.parentId,
           },
-          "getParents parentId is undefined"
+          "getParents infinite loop"
         );
-        throw new Error("getParent parentId is undefined");
+        return parents.concat(seen);
       }
       if (onProgress) {
         await onProgress();